pyOPALTools issueshttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues2019-06-24T09:55:38+02:00https://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/35Optimizer: Pareto fron json file2019-06-24T09:55:38+02:00frey_mOptimizer: Pareto fron json fileThe optimizer data set is not able to handle the additional file.The optimizer data set is not able to handle the additional file.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/34Time attribute in h5 is not recognised2019-06-19T08:22:36+02:00adelmannTime attribute in h5 is not recognisedTime attribute in h5, created by a monitor is not recognisedTime attribute in h5, created by a monitor is not recognisedadelmannadelmannhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/33add_new_files_to_doc.sh presumes bash is located in /usr/bin/bash2019-06-17T15:35:33+02:00snuverink_jjochem.snuverink@psi.chadd_new_files_to_doc.sh presumes bash is located in /usr/bin/bashAs title says, which is not portable (at least not for SL6).
https://unix.stackexchange.com/questions/206350/what-is-the-difference-if-i-start-bash-with-bin-bash-or-usr-bin-env-bash proposes instead:
`#!/usr/bin/env bash`As title says, which is not portable (at least not for SL6).
https://unix.stackexchange.com/questions/206350/what-is-the-difference-if-i-start-bash-with-bin-bash-or-usr-bin-env-bash proposes instead:
`#!/usr/bin/env bash`snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/32Documentation style Sphinx2020-04-20T11:08:56+02:00frey_mDocumentation style Sphinx@bellotti\_r changed the documentation in some classes using [Sphinx](http://www.sphinx-doc.org/en/master/). It's similar to Doxygen. We should use a consistent format. I'm fine with the new proposed documentation.@bellotti\_r changed the documentation in some classes using [Sphinx](http://www.sphinx-doc.org/en/master/). It's similar to Doxygen. We should use a consistent format. I'm fine with the new proposed documentation.snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/30Include mlmove branch into master2019-08-06T09:41:10+02:00frey_mInclude mlmove branch into master@ext\-neveu\_n Might it be possible to migrate the [mlmove](https://gitlab.psi.ch/OPAL/pyOPALTools/tree/mlmove) branch into the master?@ext\-neveu\_n Might it be possible to migrate the [mlmove](https://gitlab.psi.ch/OPAL/pyOPALTools/tree/mlmove) branch into the master?https://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/29ASCII Loss files2019-04-05T09:02:05+02:00snuverink_jjochem.snuverink@psi.chASCII Loss filesRequested by @ext\-calvo\_p : loss files (.loss) are missing.Requested by @ext\-calvo\_p : loss files (.loss) are missing.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/28Clean up timing directory2019-04-06T15:27:01+02:00frey_mClean up timing directoryfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/27Remove deprecated amrPlots directory.2019-04-06T15:27:01+02:00frey_mRemove deprecated amrPlots directory.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/26Removing of deprecated profiling directory2019-04-06T15:27:01+02:00frey_mRemoving of deprecated profiling directoryThe plots in *profiling/Memory.py* and *profiling/LoadBalancing.py* are already covered in the new opal package.The plots in *profiling/Memory.py* and *profiling/LoadBalancing.py* are already covered in the new opal package.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/25Removing deprecated pyH5root2019-04-06T15:27:01+02:00frey_mRemoving deprecated pyH5rootfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/24Switching between plotting styles does not work properly2019-04-01T15:39:50+02:00frey_mSwitching between plotting styles does not work properlyWhen calling for example the ```jupyter``` style and then the ```poster``` style, the ```matplotlib.rcParams``` are not all set.When calling for example the ```jupyter``` style and then the ```poster``` style, the ```matplotlib.rcParams``` are not all set.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/23Classes for dat a computation2019-04-06T15:27:01+02:00frey_mClasses for dat a computationAs done in #22 we should do the same for data computations.As done in #22 we should do the same for data computations.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/22Plotting Classes2019-04-06T15:27:01+02:00frey_mPlotting ClassesAs discussed with @gsell we should implement base classes for plotting in order to avoid the if-statements
```Python
if not isinstance(ds, DatasetBase):
raise TypeError("Dataset '" + ds.filename +
"' not d...As discussed with @gsell we should implement base classes for plotting in order to avoid the if-statements
```Python
if not isinstance(ds, DatasetBase):
raise TypeError("Dataset '" + ds.filename +
"' not derived from 'DatasetBase'.")
if not ds.filetype == FileType.OPTIMIZER:
raise TypeError(ds.filename + ' is not an optimizer dataset.')
```
Each dataset would also be derived from the appropriate plotter class. This would also simplify adding new methods and avoiding errors.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/21Add AMR dataset to general interface2019-04-06T15:27:00+02:00frey_mAdd AMR dataset to general interfacefrey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/20Remove duplicated code in datasets2019-04-06T15:27:00+02:00frey_mRemove duplicated code in datasetsSeveral datasets are based on the SDDS format. We should use a base class in order to get rid of duplicated code.Several datasets are based on the SDDS format. We should use a base class in order to get rid of duplicated code.https://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/19Dataset Information2019-04-06T15:27:00+02:00frey_mDataset InformationAs discussed with @snuverink_j we should add a function like ```summary``` to the dataset classes that prints the available variables etc.
- [x] DatasetBase.py
- [x] H5Dataset.py
- [x] MemoryDataset.py
- [x] PeakDataset.py
- [x] SolverD...As discussed with @snuverink_j we should add a function like ```summary``` to the dataset classes that prints the available variables etc.
- [x] DatasetBase.py
- [x] H5Dataset.py
- [x] MemoryDataset.py
- [x] PeakDataset.py
- [x] SolverDataset.py
- [x] TrackOrbitDataset.py
- [x] OptimizerDataset.py
- [x] ProbeHistDataset.py
- [x] StatDataset.py
- [x] GridDataset.py
- [x] LBalDataset.py
- [x] OutputDataset.py
- [x] SamplerDataset.py
- [x] TimeDataset.py
frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/18Logger2019-07-04T11:30:59+02:00frey_mLoggerInstall a logging system for pyOPALTools. Started with b232ef78b82f07b6ab7b1db82b3868b544a68363. Before I did the commit, I created a [tag](https://gitlab.psi.ch/OPAL/pyOPALTools/tags/pyOPALTools-0.0.1). So, the users can still have the ...Install a logging system for pyOPALTools. Started with b232ef78b82f07b6ab7b1db82b3868b544a68363. Before I did the commit, I created a [tag](https://gitlab.psi.ch/OPAL/pyOPALTools/tags/pyOPALTools-0.0.1). So, the users can still have the old behaviour.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/17JSON format change in Optimizer and Sampler2018-12-05T22:10:26+01:00frey_mJSON format change in Optimizer and SamplerThere's a JSON format change due to issue https://gitlab.psi.ch/OPAL/src/issues/259. We need therefore to adapt parsers. The new format contains a version tag such that we can still handle the deprecated data files.There's a JSON format change due to issue https://gitlab.psi.ch/OPAL/src/issues/259. We need therefore to adapt parsers. The new format contains a version tag such that we can still handle the deprecated data files.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/16Do not call plt.figure inside plotting functions2019-04-06T15:27:00+02:00frey_mDo not call plt.figure inside plotting functionsI think we shouldn't call
```python
plt.figure()
```
inside a plotting function. Otherwise we can't overlay multiple datasets.
Another solution could be of course to give a list of datasets to the plotting functions, thus, it would iter...I think we shouldn't call
```python
plt.figure()
```
inside a plotting function. Otherwise we can't overlay multiple datasets.
Another solution could be of course to give a list of datasets to the plotting functions, thus, it would iterate through them and call
```python
plt.figure()
```
only once.
It's really a design question. @snuverink_j What do you think?https://gitlab.psi.ch/OPAL/pyOPALTools/-/issues/14load_dataset not working as expected2019-04-06T15:27:00+02:00ext-roussel_rload_dataset not working as expectedHey guys, I like the new pyOPALTools, Nicole gave you a nice shoutout.
Issue: load_dataset('directory_name') doesn't return .stat file in directory_name/. Returns empty list.
RyanHey guys, I like the new pyOPALTools, Nicole gave you a nice shoutout.
Issue: load_dataset('directory_name') doesn't return .stat file in directory_name/. Returns empty list.
Ryanext-roussel_rext-roussel_r