regression-tests issueshttps://gitlab.psi.ch/OPAL/regression-tests/-/issues2019-08-01T06:07:27+02:00https://gitlab.psi.ch/OPAL/regression-tests/-/issues/68Failed kicker tests after kicker update2019-08-01T06:07:27+02:00snuverink_jjochem.snuverink@psi.chFailed kicker tests after kicker updateAfter merging src!101 and fixing src#37, the kicker regression tests fail with small error margins: http://amas.web.psi.ch/opal/regressionTests/master/results_2019-05-24.xmlAfter merging src!101 and fixing src#37, the kicker regression tests fail with small error margins: http://amas.web.psi.ch/opal/regressionTests/master/results_2019-05-24.xmlkrauskraushttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/67GasStripping test fails2019-04-23T08:19:50+02:00snuverink_jjochem.snuverink@psi.chGasStripping test failsThe `GasStripping` test fails from time to time with a too large difference for the surviving number of particles.
The `GasStripping` test checks how many particles are lost, in the reference these are 1e5 - 99623 = 377. Since this is a stochastic process, the expected error is about sqrt(377) = 20. The allowed error right now in the test is 25. [The GasStripping test failed with a difference of 42](http://amas.web.psi.ch/opal/regressionTests/OPAL-2.0/results_2019-04-16.xml). To avoid that the test fails randomly from time to time, I propose to set the allowed error to at least 2 sigma=40, perhaps even better 3 sigma=60 (also because the reference of 377 might actually not be a good estimate for the expected number).The `GasStripping` test fails from time to time with a too large difference for the surviving number of particles.
The `GasStripping` test checks how many particles are lost, in the reference these are 1e5 - 99623 = 377. Since this is a stochastic process, the expected error is about sqrt(377) = 20. The allowed error right now in the test is 25. [The GasStripping test failed with a difference of 42](http://amas.web.psi.ch/opal/regressionTests/OPAL-2.0/results_2019-04-16.xml). To avoid that the test fails randomly from time to time, I propose to set the allowed error to at least 2 sigma=40, perhaps even better 3 sigma=60 (also because the reference of 377 might actually not be a good estimate for the expected number).gsellext-calvo_ppedro.calvo@ciemat.esgsellhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/66Degrader-1 test broken2019-08-01T06:08:15+02:00krausDegrader-1 test brokenThe necessary changes to the source code to make the reference particle lose energy in a degrader (OPAL/src#298) produce different results in this test. Will have to remake the reference.The necessary changes to the source code to make the reference particle lose energy in a degrader (OPAL/src#298) produce different results in this test. Will have to remake the reference.krauskraushttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/63Regression tests for 2.02018-08-23T16:33:18+02:00snuverink_jjochem.snuverink@psi.chRegression tests for 2.0Regression tests for the 2.0 branch are not yet running.Regression tests for the 2.0 branch are not yet running.gsellgsellhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/62Degrader-1 RNG2019-04-18T10:30:27+02:00adelmannDegrader-1 RNGCheck: https://gitlab.psi.ch/OPAL/regression-tests/commit/dca0692ea675bb25ed3425587db708c2976a398c
We should use a portable rng for this test.
Maybe string RNGTYPE RANDOM (default), Quasi-random number generators: HALTON, SOBOL, NIEDERREITER (Gsl ref manual 18.5)
just use one of the Quasi-random number generators.Check: https://gitlab.psi.ch/OPAL/regression-tests/commit/dca0692ea675bb25ed3425587db708c2976a398c
We should use a portable rng for this test.
Maybe string RNGTYPE RANDOM (default), Quasi-random number generators: HALTON, SOBOL, NIEDERREITER (Gsl ref manual 18.5)
just use one of the Quasi-random number generators.adelmannadelmannhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/60EGunCTF3-1, EGunCTF3-2 and PSIGUN-12018-04-11T10:32:41+02:00adelmannEGunCTF3-1, EGunCTF3-2 and PSIGUN-1EGunCTF3-1, EGunCTF3-2 and PSIGUN-1 is working fine on merlin: not broken and results are ok.EGunCTF3-1, EGunCTF3-2 and PSIGUN-1 is working fine on merlin: not broken and results are ok.adelmannadelmannhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/59Regression tests not reported/running anymore2018-03-26T09:56:44+02:00snuverink_jjochem.snuverink@psi.chRegression tests not reported/running anymoreSince a few days the [regression tests on master](http://amas.web.psi.ch/opal/regressionTests/master/) are not reported anymore. This might have to do with OPAL/src@0e771d47?
Also the [regression tests on 1.6](http://amas.web.psi.ch/opal/regressionTests/OPAL-1.6/) are not updated since 4-1-2018. Is this on purpose?Since a few days the [regression tests on master](http://amas.web.psi.ch/opal/regressionTests/master/) are not reported anymore. This might have to do with OPAL/src@0e771d47?
Also the [regression tests on 1.6](http://amas.web.psi.ch/opal/regressionTests/OPAL-1.6/) are not updated since 4-1-2018. Is this on purpose?gsellgsellhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/56reference stat file of SAAMG-Test-1 broken2018-01-26T23:30:24+01:00gsellreference stat file of SAAMG-Test-1 brokenThe reference stat file of the SAAMG-Test-1 is broken due to an unresolved conflict before committingThe reference stat file of the SAAMG-Test-1 is broken due to an unresolved conflict before committinghttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/55Presentation of results2018-01-23T22:44:32+01:00krausPresentation of resultsWith a little use of javascript we could present the results in a tidier way: @all please look at the pictures below and comment!
![results1](/uploads/1cacbe9e37140691f666ef54e119427d/results1.png)
![results2](/uploads/804d25f50dca616c37c00c3c787ce179/results2.png)
![results3](/uploads/05f6c823ab3e545d1c6c581ea49437da/results3.png)With a little use of javascript we could present the results in a tidier way: @all please look at the pictures below and comment!
![results1](/uploads/1cacbe9e37140691f666ef54e119427d/results1.png)
![results2](/uploads/804d25f50dca616c37c00c3c787ce179/results2.png)
![results3](/uploads/05f6c823ab3e545d1c6c581ea49437da/results3.png)krausgsellsnuverink_jjochem.snuverink@psi.chkraushttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/54New reference data2018-03-20T09:35:28+01:00adelmannNew reference dataI propose (@kraus) to generate new reference data for the following tests:
EGun-CTF3-1
EGun-CTF3-2
PSIGUN-1
AWAGun-1
Quad-Simple-Test-1
At the same time the "Required Accuracy" should be set to a reasonable value. I am suggesting
1e-7 for these tests, by simply looking at the statistical fluctuations taking into account the
number of particles used in the test.I propose (@kraus) to generate new reference data for the following tests:
EGun-CTF3-1
EGun-CTF3-2
PSIGUN-1
AWAGun-1
Quad-Simple-Test-1
At the same time the "Required Accuracy" should be set to a reasonable value. I am suggesting
1e-7 for these tests, by simply looking at the statistical fluctuations taking into account the
number of particles used in the test.OPAL 1.9.xadelmannadelmannhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/53Include unit tests2019-05-08T18:03:24+02:00krausInclude unit testsThe unit tests should run (at least) every time the regression tests run. It should be easy to include the unit tests in the python script. A first step towards this is to compile the unit tests when compiling for the regression tests.The unit tests should run (at least) every time the regression tests run. It should be easy to include the unit tests in the python script. A first step towards this is to compile the unit tests when compiling for the regression tests.krausgsellkraushttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/52Regression test for injected flat-top distribution2017-12-18T17:10:19+01:00snuverink_jjochem.snuverink@psi.chRegression test for injected flat-top distributionCurrently there is no regression test for an injected flat-top distribution.
Related to issue OPAL/src#194.Currently there is no regression test for an injected flat-top distribution.
Related to issue OPAL/src#194.https://gitlab.psi.ch/OPAL/regression-tests/-/issues/50some regression-tests use removed keyword DEBIN2019-02-15T08:51:23+01:00adelmannsome regression-tests use removed keyword DEBINDEBIN was removed from the DISTRIBUTION **BUT** the regressiontests are **NOT** updated. We should avoid this ....
Sorry was not able to find out who did this ....DEBIN was removed from the DISTRIBUTION **BUT** the regressiontests are **NOT** updated. We should avoid this ....
Sorry was not able to find out who did this ....https://gitlab.psi.ch/OPAL/regression-tests/-/issues/49Remake correct references after using P0 as momentum for reference particle2018-03-26T10:04:16+02:00snuverink_jjochem.snuverink@psi.chRemake correct references after using P0 as momentum for reference particleAfter commit [14df35e](https://gitlab.psi.ch/OPAL/src/commit/14df35ee805b6add1a1ef153ef39e1128d3aa3a4) more regression tests (in master) fail (from 94 to 39 passed). The reference files need to be remade.After commit [14df35e](https://gitlab.psi.ch/OPAL/src/commit/14df35ee805b6add1a1ef153ef39e1128d3aa3a4) more regression tests (in master) fail (from 94 to 39 passed). The reference files need to be remade.krauskraushttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/46std out files2020-12-01T14:01:40+01:00adelmannstd out filesWe have to save the std out files for convenience.We have to save the std out files for convenience.adelmannadelmannhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/42Unknown variable in test BeamLine-2.in2017-08-05T15:35:54+02:00gsellUnknown variable in test BeamLine-2.in```
Error> *** in line 29 of file "BeamLine-2.in" before token ",":
Error>
Error> *** Parse error detected by function "SRefExpr::fill()"
Error>
Error> The <variable> "F" is unknown.
``````
Error> *** in line 29 of file "BeamLine-2.in" before token ",":
Error>
Error> *** Parse error detected by function "SRefExpr::fill()"
Error>
Error> The <variable> "F" is unknown.
```adelmannadelmannhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/41Neighbouring Bunches2021-06-10T19:12:25+02:00frey_mNeighbouring BunchesIt would be nice having also a regression test of a simplistic multi-bunch run. I think of 2 bunches and 2 - 3 turns.It would be nice having also a regression test of a simplistic multi-bunch run. I think of 2 bunches and 2 - 3 turns.winklehner_dwinklehner_dhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/40Regression Test are not running after commit to src2019-05-06T16:28:58+02:00adelmannRegression Test are not running after commit to src![IMG_0068](/uploads/3d85ada3a631b785258b333b72936676/IMG_0068.PNG)![IMG_0068](/uploads/3d85ada3a631b785258b333b72936676/IMG_0068.PNG)OPAL 1.6.0gsellgsellhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/39WIP: Disabled Regression Tests2018-04-01T15:03:17+02:00adelmannWIP: Disabled Regression TestsNeed to check if these tests are still be used and/or are redundant
Degrader-2
HKick-Test-2
LaserEmission-1
PROSCAN-3
PROSCAN-4
ParallelPlateFurman1
ParallelPlateVaughan1Need to check if these tests are still be used and/or are redundant
Degrader-2
HKick-Test-2
LaserEmission-1
PROSCAN-3
PROSCAN-4
ParallelPlateFurman1
ParallelPlateVaughan1OPAL 1.9.xadelmannadelmannhttps://gitlab.psi.ch/OPAL/regression-tests/-/issues/38Degrader-1 regression test - DKS2020-05-01T10:10:46+02:00Uldis LocansDegrader-1 regression test - DKSDegrader-1 test might fail using the DKS version due to a different random number sequence used on the GPU. The impact of the random number sequence on the final energy can be few keW (saw up to 29 keV on the CPU with different SEED). I believe the test if fine, but for it to pass we need either a separate reference for the GPU version, where we can guarantee the same random number sequence or we need to adjust the tolerance for Ekin (its 0.001 keV at the moment)
The CPU tests are also passing/failing even if the seed is kept the same. With the same seed on the CPU I sometimes see up to 0.2 keV difference in Ekin from the reference. I'm not sure what is the reason for this difference since the random number sequence in the CollimatorPhysics should be the same in this case.Degrader-1 test might fail using the DKS version due to a different random number sequence used on the GPU. The impact of the random number sequence on the final energy can be few keW (saw up to 29 keV on the CPU with different SEED). I believe the test if fine, but for it to pass we need either a separate reference for the GPU version, where we can guarantee the same random number sequence or we need to adjust the tolerance for Ekin (its 0.001 keV at the moment)
The CPU tests are also passing/failing even if the seed is kept the same. With the same seed on the CPU I sometimes see up to 0.2 keV difference in Ekin from the reference. I'm not sure what is the reason for this difference since the random number sequence in the CollimatorPhysics should be the same in this case.OPAL 1.9.x