Merge branch '656-logical-error-in-boundarygeometry' into 'master'

Resolve "Logical error in Boundarygeometry"

Closes #656

See merge request !502

src/Classic/AbsBeamline/ElementBase.cpp

@@ -420,7 +420,7 @@ void ElementBase::BoundingBox::print(std::ostream & out) const {
     std::vector<std::vector<unsigned int>> paths{{0, 1, 2, 3}, {0, 1, 7, 6}, {1, 2, 4, 7}, {2, 3, 5, 4}, {3, 0, 6, 5}, {4, 5, 6, 7}};
 
     out << std::setprecision(8);
-    for (const std::vector<unsigned int> path: paths) {
+    for (const std::vector<unsigned int>& path: paths) {
         for (unsigned int i : {0, 1, 2, 3, 0}) {
             const Vector_t & corner = corners[path[i]];
             out << std::setw(16) << corner(0)

src/Classic/AbsBeamline/FlexibleCollimator.cpp

@@ -46,7 +46,7 @@ FlexibleCollimator::FlexibleCollimator(const FlexibleCollimator &right):
     lossDs_m(nullptr),
     parmatint_m(NULL)
 {
-    for (const std::shared_ptr<mslang::Base> obj: right.holes_m) {
+    for (const std::shared_ptr<mslang::Base>& obj: right.holes_m) {
         holes_m.emplace_back(obj->clone());
     }
 

src/OpalParser/OpalParser.cpp

@@ -571,7 +571,7 @@ Statement *OpalParser::readStatement(TokenStream *is) const {
             stat = readStatement(is);
         } else if(token.isDel('?')) {
             // Give help.
-            *gmsg << "\ntry typing \"HELP\" or \"SHOW\" for help.\n" << endl;
+            *gmsg << "\ntry typing \"HELP\" for help.\n" << endl;
             stat = readStatement(is);
         } else if(! token.isEOF()) {
             stat = new SimpleStatement(token.getFile(), token.getLine());

src/Optimize/OpalSimulation.cpp

@@ -446,7 +446,7 @@ std::map<std::string, std::vector<double> > OpalSimulation::getData(const std::v
         std::vector<double> values;
         values.reserve(column.size());
         auto type = parser.getColumnType(var);
-        for (const auto val: column) {
+        for (const auto& val: column) {
             values.push_back(parser.getBoostVariantValue<double>(val,(int)type));
         }
         ret.insert(std::make_pair(var, values));

src/Sample/FromFile.h

@@ -96,7 +96,7 @@ public:
         std::vector<std::string> dvars({std::istream_iterator<std::string>{iss},
                                         std::istream_iterator<std::string>{}});
         size_t j = 0;
-        for (const std::string str: dvars) {
+        for (const std::string& str: dvars) {
             if (str == dvarName_m) break;
             ++ j;
         }

src/Structure/BoundaryGeometry.cpp

@@ -595,9 +595,9 @@ static inline int
 SIGN3 (
     Vector_t A
     ) {
-    return ((A[0] < EPS) ? 4 : 0 | (A[0] > -EPS) ? 32 : 0 |
-            (A[1] < EPS) ? 2 : 0 | (A[1] > -EPS) ? 16 : 0 |
-            (A[2] < EPS) ? 1 : 0 | (A[2] > -EPS) ? 8 : 0);
+    return (((A[0] < EPS) ? 4 : 0) | ((A[0] > -EPS) ? 32 : 0) |
+            ((A[1] < EPS) ? 2 : 0) | ((A[1] > -EPS) ? 16 : 0) |
+            ((A[2] < EPS) ? 1 : 0) | ((A[2] > -EPS) ? 8  : 0));
 }
 
 static int