GitLab

remove #ifdef DBG_SCALARFIELD as standard !!!! filled up my QUOTA. This should be enabled on the cmake command. Also disable the automatic dump of the particles distribution if running with one core, same reason!

Added ID.isDirty() to break condition in boundp to ensure proper update after particle termination -DW

A loss LossDataSink is initiated with the constructor, then particles are added (and locally stored).
In the finalize method all data is written to an ASCII or H5 file, depending on the NEW option ASCIIDUMP.

Testing of this is ongoing, there are maybe some gliches, watch out. 

Regressiontest will follow!

@Yianjun: please test the CYCLOTRON related PROBES and STRIPPER element!

Number of impacts are not integrated anymore, now we have impacts per timestep
OpalData can be asked if a global Geometry is avaidable

FM1DElectroStatic, FM1DElectroStatic_fast, FM1DMagnetoStatic and FM1DMagnetoStatic_fast.

The first bug had to do with field normalization. Although the 1D field profile
derivatives were normalized properly, the actual field was not. Instead of
looping through all of the field values, the loop was over the Fourier 
accuracy parameter. This typically had the effect that the on axis field was not
normalized at all. For input fields that were already normalized to 1, this
had no effect. However, if the input field was not then the field expansion
was incorrect.

The second had to do with the Fourier expansion used to calculate the 
derivatives of the on axis field. The code reflects the input
field in order to ensure that it is periodic. For best accuracy, this 
reflection should be about the first point of the input data (z = 0). However,
what was actually implemented was a reflection about -delta / 2, where delta
is the 1D grid spacing. This caused an error that was small, and became
smaller with decreasing delta, but significant. Using the new implementation,
the reconstruction of the field file for the Envelope-Tracker-Phase-1
(FINSS-RGUN.dat) is about two orders of magnitude more accurate than when
using the old Fourier expansion implementation. Even though this error was
small, there was a noticeable difference in the beam envelope when running
the Envelope-Tracker-Phase-1 and ExternalFieldTest regression tests. The
reference files for both of the tests were updated using the new field
classes.

A quick glance shows that the Fourier expansion bug may also be present in the
1D Astra field classes, but I need to look more carefully to be sure.

Finally, all six classes were cleaned up to conform to the new coding style.

Merge branch 'develop' into svn: replacing MPI_COMM_WORLDs and adding barrier before opal lib starts running

Merge branch 'develop' into svn: using caches to speed up sc calculation (mainly relevant in gun calculations with many particles)

In OPAL several different TRACK's can performed within one simulation (does not hold for OPAL-cycl yet) this together with 
the restart capabilities calls for a delicate logic.

Different tracks, looks like: 

.....

TRACK, LINE= Injector, BEAM=beam1, MAXSTEPS=100, DT=1.0e-12, ZSTOP=0.14;  
 RUN, METHOD = "PARALLEL-T", BEAM = beam1, FIELDSOLVER = Fs1, DISTRIBUTION = Dist1;
ENDTRACK;

TRACK,LINE= Injector, BEAM=beam1, MAXSTEPS=50, DT=1.0e-11, ZSTOP=0.20;
 RUN, METHOD = "PARALLEL-T", BEAM=beam1, FIELDSOLVER=Fs1;
ENDTRACK;
STOP;

A run with the arguments -restart -1 will continue a track from the last dump in the h5 file. Other the from the last track will
at the moment certainly fail in the general case. 

Changes: 

- The h5 attribute TrackStep is not longer available anymore. Two new attributes: LocalTrackStep and GlobalTrackStep are introduced instead.

- LocalTrackStep refers to the track step in a track command (0 ... 99 and 0... 49 in teh above example), where the GlobalTrackStep is the 
accumulated number of steps i.e. 0 ... 149, shown in OPAL's screen output. Both local and global track steps are also written into the h5 file 
in order to properly restart the simulation.

- The PartBunch object has get/set and increment functions:

    inline void setGlobalTrackStep(long long n) {globalTrackStep_m = n;}
    inline long long getGlobalTrackStep() const {return globalTrackStep_m;}

    inline void setLocalTrackStep(long long n) {localTrackStep_m = n;}
    inline long long getLocalTrackStep() const {return localTrackStep_m;}
    inline void incLocalTrackStep() {localTrackStep_m++; globalTrackStep_m++;)

        
- In OPAL-cyc getTrackStep is replace by getLocalTrackStep assuming we only have one TRACK in the simulation.

- In the ParallelTTracker at the end of the main loop (in execute()) obsolet code is removed (cleanup monitors etc.)
  
For details see the diff :-)

Still some work todo: 

a) Need to remove: setLastStep in ParallelTTracker.cpp and in general

    getInstance()->getLastStep()
    getInstance()->getRestartStep() maybe not!

b) The get/set and increment functions could very well be in an other class!

c) ParallelPlate tests are broken but maybe also because of other changes need to fix this 
   together with Chuang and Achim

d) Make sure the restart works in OPAL-cycl we do not have yet a regression test for that.

- use forward declaration where possible
- remove unused includes

Set Option REMOTEPARTDEL to Artifically delete the remote particle if its distance to the beam mass is larger than this factor times the beam rms size, its default values is -1 (no delete), current only valid for OPAL-cycl

heighten the doorsill for artificially deletion of the romate particles to 8*sigma in OPAL-CYCL, which is the case of quite unmatched initial beam distribution

    - removing unused file
    - moved fieldlayout, mesh and layout to OpalData
    - started using smart pointers, removed lots of issues with destructors

Merge branch 'develop' into svn: new ParallelTTracker, refactored from the old. Now default is to have units. Still lot of places that need to be cleaned up and/or fixed.