src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2018-04-11T09:12:23+02:00https://gitlab.psi.ch/OPAL/src/-/issues/219Missing header attributes for H5 in OPAl-T2018-04-11T09:12:23+02:00frey_mMissing header attributes for H5 in OPAl-TThe H5PartWrapper for OPAL-T does not write all units into the header. E.g. the phase space variables are missing. For OPAL-Cycl they are in
```
WRITESTRINGFILEATTRIB(file_m, "xUnit", "m");
WRITESTRINGFILEATTRIB(file_m, "yUnit", "m");
W...The H5PartWrapper for OPAL-T does not write all units into the header. E.g. the phase space variables are missing. For OPAL-Cycl they are in
```
WRITESTRINGFILEATTRIB(file_m, "xUnit", "m");
WRITESTRINGFILEATTRIB(file_m, "yUnit", "m");
WRITESTRINGFILEATTRIB(file_m, "zUnit", "m");
WRITESTRINGFILEATTRIB(file_m, "pxUnit", "#beta#gamma");
WRITESTRINGFILEATTRIB(file_m, "pyUnit", "#beta#gamma");
WRITESTRINGFILEATTRIB(file_m, "pzUnit", "#beta#gamma");
```OPAL 1.9.xadelmannfrey_madelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/208Destructors are noexcept(true) in C++112018-03-22T16:33:26+01:00frey_mDestructors are noexcept(true) in C++11With ```gcc/7.3.0``` one gets the following warning due to the ```CLOSE_FILE``` macro in ```LossDataSink```:
```
src/Classic/Structure/LossDataSink.cpp: In destructor 'LossDataSink::~LossDataSink()':
/scratch1/scratchdirs/frey_m/libs/op...With ```gcc/7.3.0``` one gets the following warning due to the ```CLOSE_FILE``` macro in ```LossDataSink```:
```
src/Classic/Structure/LossDataSink.cpp: In destructor 'LossDataSink::~LossDataSink()':
/scratch1/scratchdirs/frey_m/libs/opal/src/src/Classic/Structure/LossDataSink.cpp:100:70: warning: throw will always call terminate() [-Wterminate]
throw GeneralClassicException(std::string(__func__), ss.str()); \
^
/scratch1/scratchdirs/frey_m/libs/opal/src/src/Classic/Structure/LossDataSink.cpp:156:9: note: in expansion of macro 'CLOSE_FILE'
CLOSE_FILE ();
^
/scratch1/scratchdirs/frey_m/libs/opal/src/src/Classic/Structure/LossDataSink.cpp:100:70: note: in C++11 destructors default to noexcept
throw GeneralClassicException(std::string(__func__), ss.str()); \
```
As the warning explains: In C++11 destructors are ```noexcept(true)``` by default. I'll fix this by setting the destructor ```noexcept(false)``` explicitly.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/201Stat file dumping in ParallelCyclotronTracker2018-04-09T12:19:50+02:00frey_mStat file dumping in ParallelCyclotronTrackerThis issue is related to the discussion in #196. I'd like to fix the dumping and reference particle in the cyclotron tracker such that it works and gives reasonable results for single as well as multi bunch simulations. My idea is to wri...This issue is related to the discussion in #196. I'd like to fix the dumping and reference particle in the cyclotron tracker such that it works and gives reasonable results for single as well as multi bunch simulations. My idea is to write a stat-file per bunch. What do you think?OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/161PSDUMPLOCALFRAME and PSDUMPFRAME2017-08-31T10:28:35+02:00Valeria RizzoglioPSDUMPLOCALFRAME and PSDUMPFRAMEIf the list of the options is:
```
OPTION, PSDUMPLOCALFRAME=TRUE;
OPTION, PSDUMPFRAME=BUNCH_MEAN;
OPTION, TELL=TRUE;
```
OPAL starts the run without any problem.
If the list of the options is:
```
OPTION, PSDUMPFRAME=BUNCH_MEAN;
O...If the list of the options is:
```
OPTION, PSDUMPLOCALFRAME=TRUE;
OPTION, PSDUMPFRAME=BUNCH_MEAN;
OPTION, TELL=TRUE;
```
OPAL starts the run without any problem.
If the list of the options is:
```
OPTION, PSDUMPFRAME=BUNCH_MEAN;
OPTION, PSDUMPLOCALFRAME=TRUE;
OPTION, TELL=TRUE;
```
OPAL returns the following error
```
Error> *** in line 5 of file "B1_MultiMaps.in" at end of statement:
Ippl>
Ippl> *** User error detected by function "Option::handlePsDumpFrame"
Ippl> OPTION,PSDUMPLOCALFRAME=TRUE;
Ippl> Either set 'PSDUMPLOCALFRAME' Option or 'PSDUMPFRAME' Option but not both.
Ippl>
```
In addition when PSDUMPLOCALFRAME = TRUE and PSDUMPFRAME removed from the input file, the statistics is dumped in the GLOBAL frame.OPAL 1.9.xadelmannfrey_madelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/136Duplicated Bunch2017-08-13T17:23:59+02:00frey_mDuplicated Bunch```ParallelCyclotronTracker``` is a derived class of ```Tracker``` that has a protected member variable ```PartBunch```. As far as I see, the bunch is copied at construction, i.e. leading to a duplicated bunch: One stored in the instance...```ParallelCyclotronTracker``` is a derived class of ```Tracker``` that has a protected member variable ```PartBunch```. As far as I see, the bunch is copied at construction, i.e. leading to a duplicated bunch: One stored in the instance of ```Tracker``` and the other stored in ```Track::block```.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/124Reimplementation of ParallelCyclotronTracker2020-04-22T12:01:54+02:00frey_mReimplementation of ParallelCyclotronTrackerWe should re-implement the tracker such that it is independent of the integrator in order to avoid duplicated code. Adding new integrators is then also simplified.We should re-implement the tracker such that it is independent of the integrator in order to avoid duplicated code. Adding new integrators is then also simplified.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/123No stat-file output in case of MTS tracking2017-07-05T12:12:53+02:00frey_mNo stat-file output in case of MTS trackingRunning the regression test [RingCyclotronMTS](https://gitlab.psi.ch/OPAL/regression-tests/blob/master/RegressionTests/RingCyclotronMTS/RingCyclotronMTS.in) however with ```nsteps = 2000``` and ```SPTDUMPFREQ = 10``` -- as in the test [R...Running the regression test [RingCyclotronMTS](https://gitlab.psi.ch/OPAL/regression-tests/blob/master/RegressionTests/RingCyclotronMTS/RingCyclotronMTS.in) however with ```nsteps = 2000``` and ```SPTDUMPFREQ = 10``` -- as in the test [RingCyclotron](https://gitlab.psi.ch/OPAL/regression-tests/blob/master/RegressionTests/RingCyclotron/RingCyclotron.in) using RK-4 -- I get only one dump in the RingCyclotronMTS.stat.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/89Bunch Printing Format2017-04-12T16:12:15+02:00frey_mBunch Printing FormatThe format of printing the charge should be changed from ```std::fixed``` to ```std::scientific``` in the function ```getChargeString(double charge, unsigned int precision = 3)``` (file src/Classic/Utilities/Util.h) because otherwise rea...The format of printing the charge should be changed from ```std::fixed``` to ```std::scientific``` in the function ```getChargeString(double charge, unsigned int precision = 3)``` (file src/Classic/Utilities/Util.h) because otherwise really small charges are printed as zero.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/82IPPL extra message error2017-12-21T12:02:10+01:00frey_mIPPL extra message errorOPAL crashes for > 16 cores (but works with #cores = 4) with the error message
>>>
Error{0}> get_iter(): no more items in Message
Error{0}> reduce: mismatched element count in vector reduction.
Warning{0}> CommMPI: Found extra message...OPAL crashes for > 16 cores (but works with #cores = 4) with the error message
>>>
Error{0}> get_iter(): no more items in Message
Error{0}> reduce: mismatched element count in vector reduction.
Warning{0}> CommMPI: Found extra message from node 11, tag 10218: msg = Message contains 2 items (0 removed). Contents:
Warning{0}> Item 0: 1 elements, 1 bytes total, needDelete = 0
Warning{0}> Item 1: 3 elements, 24 bytes total, needDelete = 0
>>>
in case of serial x and y directions (i.e. PARFFTX=false, PARFFTY=false) and parallel z direction (i.e. PARFFTT=true). The simulation that was ran is [psiring.in](/uploads/06e3f41f765be149e96b56bd6b277485/psiring.in). The fieldmaps can be found in the repository [AMAS-BDModels / PSI-Ring](https://gitlab.psi.ch/AMAS-BDModels/PSI-Ring/tree/master/Fieldmaps). Following modules were used for running on Merlin:
>>>
module use unstable
module add gcc/5.4.0
module add openmpi/1.10.4
module add hdf5/1.8.18
module add H5hut/2.0.0rc3
module add trilinos/12.10.1
module add gsl/2.2.1
module add boost/1.62.0
>>>
When changing to parallel x, y and serial z, i.e. PARFFTX=true, PARFFTY=true and PARFFTT=false) no error occurs.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/70Regressiontest RingCyclotronMatched failed2017-08-11T10:50:28+02:00adelmannRegressiontest RingCyclotronMatched failedRegressiontest RingCyclotronMatched is failing with OPAL-1.5.x
```
OPAL{0}> *** User error detected by function "ClosedOrbitFinder::findOrbit()"
OPAL{0}> *** in line 84 of file "RingCyclotronMatched.in" at end of statement:
OPAL{0}>...Regressiontest RingCyclotronMatched is failing with OPAL-1.5.x
```
OPAL{0}> *** User error detected by function "ClosedOrbitFinder::findOrbit()"
OPAL{0}> *** in line 84 of file "RingCyclotronMatched.in" at end of statement:
OPAL{0}> RUN,METHOD="CYCLOTRON-T",BEAM=BEAM1,FIELDSOLVER=FS1,DISTRIBUTION=DIST1;
OPAL{0}> p_{r}^2 > p^{2} (defined in Gordon paper) --> Square root of negative number.
```OPAL 1.9.xfrey_mfrey_m