src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2017-11-19T13:26:34+01:00https://gitlab.psi.ch/OPAL/src/-/issues/182Autophasing gives unexpected results2017-11-19T13:26:34+01:00adelmannAutophasing gives unexpected resultsThe attached lattice works perfect in OPAL 1.4.0 and does not show autophasing information on the *master*.
IN xxxDesignPath.dat we only have NaN's.
[csu_linac.in](/uploads/d8df65871270d3d1f51bf62ca2498266/csu_linac.in)[UOF20LFCell1_B....The attached lattice works perfect in OPAL 1.4.0 and does not show autophasing information on the *master*.
IN xxxDesignPath.dat we only have NaN's.
[csu_linac.in](/uploads/d8df65871270d3d1f51bf62ca2498266/csu_linac.in)[UOF20LFCell1_B.T7](/uploads/0518005dfebb87560f7d4d796e4c683b/UOF20LFCell1_B.T7)[UOF20LHCell1_B.T7](/uploads/050945818499b0fa4b79b3fbd7c5310c/UOF20LHCell1_B.T7)
[UOF20LFCell2_B.T7](/uploads/a0d905e3e6908b712fa2daa96307e650/UOF20LFCell2_B.T7)
[UOF20S1.T7](/uploads/aa07e8534f8cec72e47148db6d45e196/UOF20S1.T7)OPAL 2.0.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/153Constraints validation fails2017-11-08T10:25:08+01:00frey_mConstraints validation failsI tried out the constraints with the condition that the number of particles should be greater than zero.
```
...
//c1: CONSTRAINT, EXPR="numParticles > 0";
//objs: OBJECTIVES=(dpeak1,dpeak2,dpeak3_5);
//constrs: CONSTRAINTS = (c1);...I tried out the constraints with the condition that the number of particles should be greater than zero.
```
...
//c1: CONSTRAINT, EXPR="numParticles > 0";
//objs: OBJECTIVES=(dpeak1,dpeak2,dpeak3_5);
//constrs: CONSTRAINTS = (c1);
//opt: OPTIMIZE, OBJECTIVES = objs, DVARS = dvars, CONSTRAINTS = constrs;
...
```
This is a dummy constraint since in our simulation we lose no particles. 'numParticles' is part of the SDDS file, i.e. *.stat file (OPAL 1.6).
For some reason -- I do not understand -- I get following message in [opt.trace.0](/uploads/71d42dd821ddfcc95d3fa165cb5ef5ad/opt.trace.0):
```
invalid individual, constraint "c1" failed to yield true; result: 0
```
OPT-Pilot never finds a solution. Without the constraint, it works fine. The template and data file attached:
[Ring.tmpl](/uploads/c94789c099aa26a0d20acd0daca29f93/Ring.tmpl)
[Ring.data](/uploads/95c2dac28b6a7785e708cc363977957c/Ring.data)
Best,
Matthias :bug:snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/179opt-pilot CONSTRAINT command not known2017-11-07T10:03:58+01:00snuverink_jjochem.snuverink@psi.chopt-pilot CONSTRAINT command not knownA opt-pilot constraint such as:
```
c1: CONSTRAINT, EXPR="fabs(rms_x)<1.5e-2";
constrs: CONSTRAINTS = (c1);
```
gives:
```
Error>
Error> *** Parse error detected by function "OpalParser::parseDefine()"
Error> *** in line 46 of file "...A opt-pilot constraint such as:
```
c1: CONSTRAINT, EXPR="fabs(rms_x)<1.5e-2";
constrs: CONSTRAINTS = (c1);
```
gives:
```
Error>
Error> *** Parse error detected by function "OpalParser::parseDefine()"
Error> *** in line 46 of file "RingOpt.in" before token ",":
Error> The object "CONSTRAINT" is unknown.
```
This is because the keyword CONSTRAINT is not skipped in [AbsFileStream](https://gitlab.psi.ch/OPAL/src/blob/master/src/Classic/Parser/AbsFileStream.cpp#L42).
I will fix this there.
One concern is that CONSTRAINT is also a keyword in the match routine: https://gitlab.psi.ch/OPAL/src/blob/master/src/Match/MatchParser.cpp.
However, as far as I can see this is currently not in OPAL? Quoting the manual: "Please note this is not yet available in: `DOPAL-t` and `DOPAL-cycl`." @adelmann can you confirm?snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/177python xxxx_ElementPositions.py --export-web2017-11-06T22:50:24+01:00adelmannpython xxxx_ElementPositions.py --export-web`adelmann@eduroam062-061 ~/Desktop/ANL/optLinac_40nC/data $ python optLinac_40nC_ElementPositions.py --export-web
Traceback (most recent call last):
File "optLinac_40nC_ElementPositions.py", line 590, in <module>
exportWeb()
File...`adelmann@eduroam062-061 ~/Desktop/ANL/optLinac_40nC/data $ python optLinac_40nC_ElementPositions.py --export-web
Traceback (most recent call last):
File "optLinac_40nC_ElementPositions.py", line 590, in <module>
exportWeb()
File "optLinac_40nC_ElementPositions.py", line 170, in exportWeb
decodeVertices()
File "optLinac_40nC_ElementPositions.py", line 16, in decodeVertices
for i in xrange(len(numVertices)):
NameError: name 'xrange' is not defined`
[optLinac_40nC_ElementPositions.py](/uploads/06f0c11ef6d6f05fcc0b40f43b8b7e67/optLinac_40nC_ElementPositions.py)OPAL 1.9.xkrauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/162K0 attribute in RBend2017-10-22T14:14:11+02:00Valeria RizzoglioK0 attribute in RBendIt seems that the attribute K0 (to set the magnetic field) is not working in the RBend element.
In the regression test, if I am not wrong, only the Angle attribute is tested.
From a simple RBend test:
1- if **ANGLE** attribute is us...It seems that the attribute K0 (to set the magnetic field) is not working in the RBend element.
In the regression test, if I am not wrong, only the Angle attribute is tested.
From a simple RBend test:
1- if **ANGLE** attribute is used
```
RBend [2]> 1DPROFILE1-DEFAULT (1D Profile type 1)
RBend [2]> BEND using file 1DPROFILE1-DEFAULT (1D Profile type 1)
RBend [2]>
RBend [2]> Start of field map: 0.146472 m (in s coordinates)
RBend [2]> End of field map: 0.484418 m (in s coordinates)
RBend [2]> Entrance edge of magnet: 0.25 m (in s coordinates)
RBend [2]>
RBend [2]> Reference Trajectory Properties
RBend [2]> ===============================
RBend [2]>
RBend [2]> Bend angle magnitude: 0.523599 rad (30 degrees)
RBend [2]> Entrance edge angle: 0.261799 rad (15 degrees)
RBend [2]> Exit edge angle: 0.261799 rad (15 degrees)
RBend [2]> Bend design radius: 0.249982 m
RBend [2]> Bend design energy: 7e+06 eV
RBend [2]>
RBend [2]> Bend Field and Rotation Properties
RBend [2]> ==================================
RBend [2]>
RBend [2]> Field amplitude: 1.53217 T
RBend [2]> Field index: 0
RBend [2]> Rotation about x axis: 0 rad (0 degrees)
RBend [2]> Rotation about y axis: 0 rad (0 degrees)
RBend [2]> Rotation about z axis: 0 rad (0 degrees)
RBend [2]>
RBend [2]> Reference Trajectory Properties Through Bend Magnet with Fringe Fields
RBend [2]> ======================================================================
RBend [2]>
RBend [2]> Reference particle is bent: 0.523599 rad (30 degrees) in x plane
RBend [2]> Reference particle is bent: 0 rad (0 degrees) in y plane
RBend [2]>
```
2- if **K0** attribute is used:
```
RBend [2]> 1DPROFILE1-DEFAULT (1D Profile type 1)
RBend [2]> BEND using file 1DPROFILE1-DEFAULT (1D Profile type 1)
RBend [2]>
RBend [2]> Start of field map: 0.146472 m (in s coordinates)
RBend [2]> End of field map: -nan m (in s coordinates)
RBend [2]> Entrance edge of magnet: 0.25 m (in s coordinates)
RBend [2]>
RBend [2]> Reference Trajectory Properties
RBend [2]> ===============================
RBend [2]>
RBend [2]> Bend angle magnitude: -nan rad (-nan degrees)
RBend [2]> Entrance edge angle: 0.261799 rad (15 degrees)
RBend [2]> Exit edge angle: -0.261799 rad (-15 degrees)
RBend [2]> Bend design radius: 0.25001 m
RBend [2]> Bend design energy: 7e+06 eV
RBend [2]>
RBend [2]> Bend Field and Rotation Properties
RBend [2]> ==================================
RBend [2]>
RBend [2]> Field amplitude: 1.532 T
RBend [2]> Field index: 0
RBend [2]> Rotation about x axis: 0 rad (0 degrees)
RBend [2]> Rotation about y axis: 0 rad (0 degrees)
RBend [2]> Rotation about z axis: 0 rad (0 degrees)
RBend [2]>
RBend [2]> Reference Trajectory Properties Through Bend Magnet with Fringe Fields
RBend [2]> ======================================================================
RBend [2]>
RBend [2]> Reference particle is bent: -0 rad (-0 degrees) in x plane
RBend [2]> Reference particle is bent: 0 rad (0 degrees) in y plane
RBend [2]>
```
Could, please, someone check?OPAL 2.0.0adelmannkrausadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/171OPAL-t wrong results2017-10-22T10:10:53+02:00adelmannOPAL-t wrong resultsThe attached input files give a consistent solutions in V1.4 and V1.6 as
demonstrated in regtest.pdf.
[regtest.pdf](/uploads/57c7e0d924b6ae43095fe9b0ca133088/regtest.pdf)
With 1.9.x depending on the BFREQ we get a different set of so...The attached input files give a consistent solutions in V1.4 and V1.6 as
demonstrated in regtest.pdf.
[regtest.pdf](/uploads/57c7e0d924b6ae43095fe9b0ca133088/regtest.pdf)
With 1.9.x depending on the BFREQ we get a different set of solutions:
![v1.9err_2](/uploads/221e8b0cd7f810cc8eafaa1c8ac85fa9/v1.9err_2.png)
In case of Hz as units the energy is correct in case of MHz (as it should be)
the energy is wrong.
In both cases Autophase finds the correct energy.
[M_440.T7](/uploads/01c55ee8da1bcbc085eafbf42c7d9338/M_440.T7)
[DriveGun.T7](/uploads/015112fe7906c295a044d37b941c673a/DriveGun.T7)
[BF_550.T7](/uploads/1b31be08c1ea892ed0bfb23110e2310d/BF_550.T7)
[RFphotoinjector-1.9.in](/uploads/7bd8b3675626b4f84e2816f19bea1c74/RFphotoinjector-1.9.in)OPAL 2.0.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/166Placement of elements with PSI different from 0 and pi2017-10-15T22:12:10+02:00krausPlacement of elements with PSI different from 0 and piThe elements between dipoles are placed incorrectly when the dipoles have e.g. PSI = pi/2.The elements between dipoles are placed incorrectly when the dipoles have e.g. PSI = pi/2.OPAL 2.0.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/163Charge zero in OPAL-cycl & OPAL-t2017-10-02T09:29:53+02:00adelmannCharge zero in OPAL-cycl & OPAL-tCompare beam size of 1.6 and 1.9.x
![opal-cycl](/uploads/e0253f94e8aaec164cae26c992f33eab/opal-cycl.png)
for the IsoDAR cyclotron. Inputfiles can be found on
`merlin-l-01: /gpfs/home/adelmann/scratch/UQ/isodar-1/Accelerated and
...Compare beam size of 1.6 and 1.9.x
![opal-cycl](/uploads/e0253f94e8aaec164cae26c992f33eab/opal-cycl.png)
for the IsoDAR cyclotron. Inputfiles can be found on
`merlin-l-01: /gpfs/home/adelmann/scratch/UQ/isodar-1/Accelerated and
...../Accelerated-1.9`
FUN fact: **Qtot = 0.000**
`
OPAL{0}> * ************** B U N C H *********************************************************
OPAL{0}> * NP = 133000
OPAL{0}> * Qtot = 0.000 [fC] Qi = 1.017 [fC]
OPAL{0}> * Ekin = 361.221 [keV] dEkin = 1.445 [keV]
OPAL{0}> * rmax = ( 3.18003 , 8.91427 , 9.34380 ) [um]
OPAL{0}> * rmin = ( -3.18003 , -8.95209 , -9.36713 ) [um]
OPAL{0}> * rms beam size = ( 1.02826 , 2.91108 , 3.02269 ) [mm]
OPAL{0}> * rms momenta = ( 1.70888e-04 , 3.92498e-05 , 7.85035e-05 ) [beta gamma]
OPAL{0}> * mean position = ( 0.00000 , -0.00000 , 0.00009 ) [um]
OPAL{0}> * mean momenta = ( 2.92045e-15 , 1.96206e-02 , -1.26375e-09 ) [beta gamma]
OPAL{0}> * rms emittance = ( 8.78539e-06 , 5.71264e-06 , 1.18639e-05 ) (not normalized)
OPAL{0}> * rms correlation = ( 2.39105e-04 , 1.14814e-03 , 1.85573e-03 )
OPAL{0}> * hr = ( 0.44096 , 1.23873 , 1.29729 ) [mm]
OPAL{0}> * dh = 2.00000e+00 [%]
OPAL{0}> * t = 0.000 [fs] dT = 28.251 [ps]
OPAL{0}> * spos = 0.000 [um]
OPAL{0}> * **********************************************************************************
`OPAL 1.9.xadelmannwinklehner_dadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/164Compiling OPAL on Daint causes internal compiler error2017-09-18T10:18:43+02:00frey_mCompiling OPAL on Daint causes internal compiler errorWhen compiling OPAL on Piz Daint one obtains an internal compiler error
```
/users/freym/git/opal/src/opt-pilot/Util/MPIHelper.cpp:36:11: required from here
/users/freym/git/opal/src/opt-pilot/Util/Types.h:50:16: internal compiler err...When compiling OPAL on Piz Daint one obtains an internal compiler error
```
/users/freym/git/opal/src/opt-pilot/Util/MPIHelper.cpp:36:11: required from here
/users/freym/git/opal/src/opt-pilot/Util/Types.h:50:16: internal compiler error: Segmentation fault
typedef struct {
^
0xb0248f crash_signal
../../cray-gcc-5.3.0/gcc/toplev.c:383
0xafa0ff layout_decl(tree_node*, unsigned int)
../../cray-gcc-5.3.0/gcc/stor-layout.c:783
0x660ba4 require_complete_types_for_parms
../../cray-gcc-5.3.0/gcc/cp/decl.c:11148
0x660ba4 check_function_type
../../cray-gcc-5.3.0/gcc/cp/decl.c:13297
0x660ba4 start_preparsed_function(tree_node*, tree_node*, int)
../../cray-gcc-5.3.0/gcc/cp/decl.c:13471
0x70f654 synthesize_method(tree_node*)
../../cray-gcc-5.3.0/gcc/cp/method.c:798
0x6b29f3 mark_used(tree_node*, int)
../../cray-gcc-5.3.0/gcc/cp/decl2.c:5196
0x651dc4 build_over_call
../../cray-gcc-5.3.0/gcc/cp/call.c:7536
0x650976 build_new_method_call_1
../../cray-gcc-5.3.0/gcc/cp/call.c:8252
0x650976 build_new_method_call(tree_node*, tree_node*, vec<tree_node*, va_gc, vl_embed>**, tree_node*, int, tree_node**, int)
../../cray-gcc-5.3.0/gcc/cp/call.c:8322
0x64a6ba build_special_member_call(tree_node*, tree_node*, vec<tree_node*, va_gc, vl_embed>**, tree_node*, int, int)
../../cray-gcc-5.3.0/gcc/cp/call.c:7862
0x709877 build_value_init(tree_node*, int)
../../cray-gcc-5.3.0/gcc/cp/init.c:358
0x70de58 perform_member_init
../../cray-gcc-5.3.0/gcc/cp/init.c:646
0x70de58 emit_mem_initializers(tree_node*)
../../cray-gcc-5.3.0/gcc/cp/init.c:1167
0x684656 tsubst_expr
../../cray-gcc-5.3.0/gcc/cp/pt.c:13962
0x6844fc tsubst_expr
../../cray-gcc-5.3.0/gcc/cp/pt.c:14142
0x683267 instantiate_decl(tree_node*, int, bool)
../../cray-gcc-5.3.0/gcc/cp/pt.c:20589
0x6b271d mark_used(tree_node*, int)
../../cray-gcc-5.3.0/gcc/cp/decl2.c:5217
0x651dc4 build_over_call
../../cray-gcc-5.3.0/gcc/cp/call.c:7536
0x650976 build_new_method_call_1
../../cray-gcc-5.3.0/gcc/cp/call.c:8252
Please submit a full bug report,
```frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/158Somehow PSDump has influence on dumped statistics2017-08-18T09:32:49+02:00krausSomehow PSDump has influence on dumped statistics[red has PSDump simultaneously](/uploads/f289a4e3acd9d43703dc6b5c9c5c50fe/influencePSDump.png) This doesn't hurt any further but it's annoying.[red has PSDump simultaneously](/uploads/f289a4e3acd9d43703dc6b5c9c5c50fe/influencePSDump.png) This doesn't hurt any further but it's annoying.OPAL 1.6.0adelmannadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/151OPAL does not compile with DKS enabled after recent commits2017-08-14T21:21:16+02:00gsellOPAL does not compile with DKS enabled after recent commits@kraus, @uldis_l:
```
59%] Building CXX object src/CMakeFiles/OPALib.dir/Classic/Structure/LossDataSink.cpp.o
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:38:30: error: ‘const int Coll...@kraus, @uldis_l:
```
59%] Building CXX object src/CMakeFiles/OPALib.dir/Classic/Structure/LossDataSink.cpp.o
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:38:30: error: ‘const int CollimatorPhysics::numpar’ is not a static data member of ‘class CollimatorPhysics’
const int CollimatorPhysics::numpar = 13;
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp: In constructor ‘CollimatorPhysics::CollimatorPhysics(const string&, ElementBase*, std::__cxx11::string&, bool, double)’:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:77:7: error: class ‘CollimatorPhysics’ does not have any field named ‘curandInitSet’
, curandInitSet(0)
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:78:7: error: class ‘CollimatorPhysics’ does not have any field named ‘ierr’
, ierr(0)
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:79:7: error: class ‘CollimatorPhysics’ does not have any field named ‘maxparticles’
, maxparticles(0)
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:80:7: error: class ‘CollimatorPhysics’ does not have any field named ‘numparticles’
, numparticles(0)
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:81:7: error: class ‘CollimatorPhysics’ does not have any field named ‘par_ptr’
, par_ptr(NULL)
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:82:7: error: class ‘CollimatorPhysics’ does not have any field named ‘mem_ptr’
, mem_ptr(NULL)
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp: In member function ‘void CollimatorPhysics::applyDKS(PartBunch&, size_t)’:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:875:58: error: cannot allocate an object of abstract type ‘Degrader’
Degrader deg = dynamic_cast<Degrader *>(element_ref_m);
^
In file included from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.hh:16:0,
from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:9:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/Degrader.h:38:7: note: because the following virtual functions are pure within ‘Degrader’:
class Degrader: public Component {
^
In file included from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/Component.h:26:0,
from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.hh:14,
from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:9:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/ElementBase.h:190:29: note: virtual BGeometryBase& ElementBase::getGeometry()
virtual BGeometryBase &getGeometry() = 0;
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/ElementBase.h:195:35: note: virtual const BGeometryBase& ElementBase::getGeometry() const
virtual const BGeometryBase &getGeometry() const = 0;
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/ElementBase.h:311:26: note: virtual ElementBase* ElementBase::clone() const
virtual ElementBase *clone() const = 0;
^
In file included from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.hh:14:0,
from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:9:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/Component.h:64:22: note: virtual EMField& Component::getField()
virtual EMField &getField() = 0;
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/AbsBeamline/Component.h:69:28: note: virtual const EMField& Component::getField() const
virtual const EMField &getField() const = 0;
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:875:14: error: cannot declare variable ‘deg’ to be of abstract type ‘Degrader’
Degrader deg = dynamic_cast<Degrader *>(element_ref_m);
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:878:60: error: no matching function for call to ‘CollimatorPhysics::setupCollimatorDKS(PartBunch&, Degrader&, size_t&)’
setupCollimatorDKS(bunch, deg, numParticlesInSimulation);
^
In file included from /home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:9:0:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.hh:110:10: note: candidate: void CollimatorPhysics::setupCollimatorDKS(PartBunch&, Degrader*, size_t)
void setupCollimatorDKS(PartBunch &bunch, Degrader *deg, size_t numParticlesInSimulation);
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.hh:110:10: note: no known conversion for argument 2 from ‘Degrader’ to ‘Degrader*’
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp: In member function ‘void CollimatorPhysics::setupCollimatorDKS(PartBunch&, Degrader*, size_t)’:
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:1063:51: error: ‘numpar’ was not declared in this scope
par_mp = dksbase_m.allocateMemory<double>(numpar, ierr_m);
^
/home/opalci/NightlyBuild/workspace/OPAL-1.6-DKS/src/src/Classic/Solvers/CollimatorPhysics.cpp:1082:50: error: ‘class Degrader’ has no member named ‘getZSize’
double params[numpar_ms] = {zBegin, deg->getZSize(), rho_m, Z_m,
^
make[2]: *** [src/CMakeFiles/OPALib.dir/Classic/Solvers/CollimatorPhysics.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/CMakeFiles/OPALib.dir/all] Error 2
make: *** [all] Error 2
```krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/132_M_range_check error2017-08-13T10:13:16+02:00winklehner_d_M_range_check errorSince pulling today, this happens:
```
Error{1}> *** Error:
Error{1}> *** in line 86 of file "RFQ_VECC-T.in":
Error{1}> RUN,METHOD="PARALLEL-T",BEAM=BEAM1,FIELDSOLVER=FS1,DISTRIBUTION=DIST;
Error{1}> vector::_M_range_check
...Since pulling today, this happens:
```
Error{1}> *** Error:
Error{1}> *** in line 86 of file "RFQ_VECC-T.in":
Error{1}> RUN,METHOD="PARALLEL-T",BEAM=BEAM1,FIELDSOLVER=FS1,DISTRIBUTION=DIST;
Error{1}> vector::_M_range_check
```
Any insights anyone? @kraus, did you write something about distributions now being arrays? @adelmann?https://gitlab.psi.ch/OPAL/src/-/issues/129Array of distributions containing FROMFILE2017-08-13T10:13:16+02:00krausArray of distributions containing FROMFILEThis won't work properly because e.g. the number of particles in a FROMFILE distribution is fixed. Thus when computing the number of particles the other distributions should contain we have first to subtract the number of particles in th...This won't work properly because e.g. the number of particles in a FROMFILE distribution is fixed. Thus when computing the number of particles the other distributions should contain we have first to subtract the number of particles in the FROMFILE distributions.OPAL 1.6.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/70Regressiontest RingCyclotronMatched failed2017-08-11T10:50:28+02:00adelmannRegressiontest RingCyclotronMatched failedRegressiontest RingCyclotronMatched is failing with OPAL-1.5.x
```
OPAL{0}> *** User error detected by function "ClosedOrbitFinder::findOrbit()"
OPAL{0}> *** in line 84 of file "RingCyclotronMatched.in" at end of statement:
OPAL{0}>...Regressiontest RingCyclotronMatched is failing with OPAL-1.5.x
```
OPAL{0}> *** User error detected by function "ClosedOrbitFinder::findOrbit()"
OPAL{0}> *** in line 84 of file "RingCyclotronMatched.in" at end of statement:
OPAL{0}> RUN,METHOD="CYCLOTRON-T",BEAM=BEAM1,FIELDSOLVER=FS1,DISTRIBUTION=DIST1;
OPAL{0}> p_{r}^2 > p^{2} (defined in Gordon paper) --> Square root of negative number.
```OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/93SAAMG-Test-1.in PARALLEL2017-08-09T21:28:33+02:00adelmannSAAMG-Test-1.in PARALLEL
The test is from git@gitlab.psi.ch:OPAL/regression-tests.git
and the `git checkout OPAL-1.6`
Parallel run fails, serial is ok.
```
mpirun -np 4 opal SAAMG-Test-1.in
* Node:0, Filling RHS...
* Node:1, Filling RHS...
* Nod...
The test is from git@gitlab.psi.ch:OPAL/regression-tests.git
and the `git checkout OPAL-1.6`
Parallel run fails, serial is ok.
```
mpirun -np 4 opal SAAMG-Test-1.in
* Node:0, Filling RHS...
* Node:1, Filling RHS...
* Node:1, Rho for final element: 0.0000000000000000e+00
* Node:2, Filling RHS...
* Node:2, Rho for final element: 0.0000000000000000e+00
* Node:2, Local nx*ny*nz = 1575
* Node:2, Number of reserved local elements in RHS: 832
* Node:2, Number of reserved global elements in RHS: 3328
* Node:3, Filling RHS...
* Node:3, Rho for final element: 0.0000000000000000e+00
* Node:3, Local nx*ny*nz = 3375
* Node:3, Number of reserved local elements in RHS: 832
* Node:3, Number of reserved global elements in RHS: 3328
* Node:0, Rho for final element: 0.0000000000000000e+00
* Node:0, Local nx*ny*nz = 735
* Node:0, Number of reserved local elements in RHS: 832
* Node:0, Number of reserved global elements in RHS: 3328
* Node:1, Local nx*ny*nz = 1575
* Node:1, Number of reserved local elements in RHS: 832
* Node:1, Number of reserved global elements in RHS: 3328
* Node:2, Number of Local Inside Points 832
* Node:0, Number of Local Inside Points 832
* Node:3, Number of Local Inside Points 832
* Node:3, Done.
* Node:0, Done.
* Node:1, Number of Local Inside Points 832
* Node:1, Done.
* Node:2, Done.
[fast-dude:02195] *** Process received signal ***
[fast-dude:02195] Signal: Segmentation fault: 11 (11)
[fast-dude:02195] Signal code: Address not mapped (1)
[fast-dude:02195] Failing at address: 0x7fe2336ae600
[fast-dude:02195] *** End of error message ***
--------------------------------------------------------------------------
mpirun noticed that process rank 3 with PID 2195 on node fast-dude exited on signal 11 (Segmentation fault: 11).
--------------------------------------------------------------------------
```OPAL 2.0.0Yves IneichenYves Ineichenhttps://gitlab.psi.ch/OPAL/src/-/issues/138Setting autophase option without a cavity in beamline throws mysterious error2017-08-05T20:04:40+02:00ext-hall_cSetting autophase option without a cavity in beamline throws mysterious errorWith `"OPTION, AUTOPHASE=4;"` in my input file when I use a beamline without a cavity I see an error like:
`opal(7879,0x7fff7f140000) malloc: *** error for object 0x7fff9a15b9f3: pointer being freed was not allocated`
Turning autophase...With `"OPTION, AUTOPHASE=4;"` in my input file when I use a beamline without a cavity I see an error like:
`opal(7879,0x7fff7f140000) malloc: *** error for object 0x7fff9a15b9f3: pointer being freed was not allocated`
Turning autophase off allowed my input file to run without error, but this error was not very informative and it took quite a while to find the culprit. It might be helpful if making this mistake generated a specific error message.OPAL 1.6.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/140Particle delete2017-08-05T14:31:50+02:00adelmannParticle deleteWith OPAL-1.6 (newest pull) and Regressiontest PSIGUN-1 Bin 0 gets no particles at timestep 2:
....
OPAL {0}[3]> * Wrote beam statistics.
Ippl{0}[2]> Bin 0 gamma = 1.00717e+00; NpInBin= 667
Ippl{0}[2]> Bin 1 has...With OPAL-1.6 (newest pull) and Regressiontest PSIGUN-1 Bin 0 gets no particles at timestep 2:
....
OPAL {0}[3]> * Wrote beam statistics.
Ippl{0}[2]> Bin 0 gamma = 1.00717e+00; NpInBin= 667
Ippl{0}[2]> Bin 1 has no particles
Ippl{0}[2]> Bin 2 has no particles
Ippl{0}[2]> Bin 3 has no particles
Ippl{0}[2]> Bin 4 has no particles
Ippl{0}[3]> * Bin number: 2 has emitted all particles (new emit).
ParallelTTracker {0}> * Deleted 667 particles, remaining 4755 particles
ParallelTTracker {0}[3]> 12:03:09 Step 1 at -0.053 [mm] t= 1.060e-11 [s] E= 5.388 [keV]
...
OPAL {0}>
OPAL {0}[3]> * Wrote beam statistics.
Ippl{0}[2]> Bin 0 has no particles
Ippl{0}[2]> Bin 1 gamma = 1.01054e+00; NpInBin= 4755
Ippl{0}[2]> Bin 2 has no particles
Later on we are running into
I + M < LocalSize
@kraus Is there still an autophpse problem?OPAL 1.6.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/133BeamLine fails isInside test during OrbitThreader execute() when Aperture CIR...2017-08-02T22:49:58+02:00winklehner_dBeamLine fails isInside test during OrbitThreader execute() when Aperture CIRCLE is defined in RFCavity.It took me a long time to find out why my RFCavity was not in the imap_m generated by the OrbitThreader during execute(), so I wasn't able to test this with other apertures, but it seems that having a "CIRCLE(0.008, 1)" aperture defined ...It took me a long time to find out why my RFCavity was not in the imap_m generated by the OrbitThreader during execute(), so I wasn't able to test this with other apertures, but it seems that having a "CIRCLE(0.008, 1)" aperture defined in the RFCavity element prevents it from being added to the elementSet list in the getElements(nextR) function. I think the culprit is somehow the ElementBase::isInsideTransverse() function.krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/72Removal of data from a particle without reducing number of particles2017-07-24T10:29:37+02:00krausRemoval of data from a particle without reducing number of particlesThis leads to wrong results: https://gitlab.psi.ch/OPAL/src/blob/OPAL-1.6/src/Classic/Algorithms/PartBunch.cpp#L1930 . This is as if replacing position and momentum with zero.
Please remember to add the patch that solves this issue to ...This leads to wrong results: https://gitlab.psi.ch/OPAL/src/blob/OPAL-1.6/src/Classic/Algorithms/PartBunch.cpp#L1930 . This is as if replacing position and momentum with zero.
Please remember to add the patch that solves this issue to the master as well.adelmannadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/103Overlap of field maps OPAL-cycl2017-07-24T10:29:37+02:00adelmannOverlap of field maps OPAL-cyclCommunicated by @zhang_h
Case maps for COMET.
We have four non-superpose RF maps and one superpose electrostatic map. The read-in loop could be stopped at the third RF map, without reading the electrostatic map. We may put the ...Communicated by @zhang_h
Case maps for COMET.
We have four non-superpose RF maps and one superpose electrostatic map. The read-in loop could be stopped at the third RF map, without reading the electrostatic map. We may put the electrostatic map in front, but it could cause other problem.OPAL 1.9.xadelmannadelmann