src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2023-10-17T13:26:49+02:00https://gitlab.psi.ch/OPAL/src/-/issues/787VariableRF, FFA, Offset and MultipoleT: unify units internally2023-10-17T13:26:49+02:00ext-calvo_ppedro.calvo@ciemat.esVariableRF, FFA, Offset and MultipoleT: unify units internallyPart of #357: all elements should use the same units internally to eliminate unnecessary conversions and less error-prone.
VariableRF, FFA, Offset and MultipoleT elements use `mm` internally even though the input attributes are correctl...Part of #357: all elements should use the same units internally to eliminate unnecessary conversions and less error-prone.
VariableRF, FFA, Offset and MultipoleT elements use `mm` internally even though the input attributes are correctly implemented in `m`2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/773Cyclotron: unify units internally2023-09-22T14:29:46+02:00ext-calvo_ppedro.calvo@ciemat.esCyclotron: unify units internallyAccording to #357, all elements should use the same units internally to eliminate unnecessary conversions and less error-prone. Unit conversion should be done for input parameters upon reading the variables.According to #357, all elements should use the same units internally to eliminate unnecessary conversions and less error-prone. Unit conversion should be done for input parameters upon reading the variables.2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/785h5 file initialization2023-09-20T15:10:25+02:00ext-calvo_ppedro.calvo@ciemat.esh5 file initializationThe output file in HDF5 format (.h5) should be created only when the option `ENABLEHDF5 = TRUE`. Currently, when this option is not selected, an empty file is created. In addition, the `H5PartWrapper` call can be refactored to avoid code...The output file in HDF5 format (.h5) should be created only when the option `ENABLEHDF5 = TRUE`. Currently, when this option is not selected, an empty file is created. In addition, the `H5PartWrapper` call can be refactored to avoid code duplication.2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/783Define AMR refinement criteria as scoped enum2023-09-18T16:25:13+02:00ext-calvo_ppedro.calvo@ciemat.esDefine AMR refinement criteria as scoped enumTaggingCriteria must be defined as a scoped enumeration to avoid string comparisonTaggingCriteria must be defined as a scoped enumeration to avoid string comparison2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/772Define TrimCoilType enum2023-08-30T09:38:40+02:00ext-calvo_ppedro.calvo@ciemat.esDefine TrimCoilType enumThe type of trim coil must be defined as a scoped enumeration to avoid string comparisonThe type of trim coil must be defined as a scoped enumeration to avoid string comparison2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/776Remove string comparison in MultiBunchHandler2023-08-29T15:25:01+02:00ext-calvo_ppedro.calvo@ciemat.esRemove string comparison in MultiBunchHandler`setMode` and `setBining` methods can be rewritten to avoid string comparison`setMode` and `setBining` methods can be rewritten to avoid string comparison2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/694Replace plain enum by enum class2023-08-28T12:37:41+02:00ext-calvo_ppedro.calvo@ciemat.esReplace plain enum by enum classSince C++11 scoped enumerations (`enum class`) overcomes a lot of the drawbacks of classical enumerations. Some plain enum may be substituted throughout the code, such as e.g. `ElementType` or `DistrTypeT`.Since C++11 scoped enumerations (`enum class`) overcomes a lot of the drawbacks of classical enumerations. Some plain enum may be substituted throughout the code, such as e.g. `ElementType` or `DistrTypeT`.2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/769remove deprecated Tpetra::StaticProfil2023-08-15T16:30:31+02:00gsellremove deprecated Tpetra::StaticProfil2023.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/762RFCavity: unify units internally2023-05-09T10:21:56+02:00ext-calvo_ppedro.calvo@ciemat.esRFCavity: unify units internallyAccording to #357, all elements should use the same units internally to eliminate unnecessary conversions and less error-prone. Unit conversion should be done for input parameters upon reading the variables.According to #357, all elements should use the same units internally to eliminate unnecessary conversions and less error-prone. Unit conversion should be done for input parameters upon reading the variables.2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/761Remove duplicate function to check integers2023-05-09T08:03:32+02:00ext-calvo_ppedro.calvo@ciemat.esRemove duplicate function to check integersDumpFields and DumpEMFields have repeated methods to check if an input variable is an integer. A new method could be created to avoid duplication in Util namespaceDumpFields and DumpEMFields have repeated methods to check if an input variable is an integer. A new method could be created to avoid duplication in Util namespace2023.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/754boost::filesystem::extension() is deprecated in new boost versions2023-04-05T09:50:50+02:00gsellboost::filesystem::extension() is deprecated in new boost versions2023.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/755Tpetra CsrMatrix::getNodeNumElements() is deprecated2023-04-05T09:08:35+02:00gsellTpetra CsrMatrix::getNodeNumElements() is deprecated2023.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/753fix assigned but unused variable warnings2023-04-05T09:08:00+02:00gsellfix assigned but unused variable warningsWith Clang 14 on macOS 13.3 and Xcode 14.3 we get several warning about variables assigned but not used. In some cases the value is used only if some debug output is enabled.With Clang 14 on macOS 13.3 and Xcode 14.3 we get several warning about variables assigned but not used. In some cases the value is used only if some debug output is enabled.2023.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/752replace deprecated sprintf2023-03-31T14:16:36+02:00gsellreplace deprecated sprintf2023.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/733minor code cleanup2022-09-14T11:28:02+02:00gsellminor code cleanup* remove commented out source code
* don't include files which are not used
* ...* remove commented out source code
* don't include files which are not used
* ...2022.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/732fix Apple Clang warnings2022-09-14T11:27:49+02:00gsellfix Apple Clang warningsApple Clang 13 on Apple Silicon complains about several minor issue like unused variables, missing override declarations etc.Apple Clang 13 on Apple Silicon complains about several minor issue like unused variables, missing override declarations etc.2022.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/731minor fixes in the main CMake configuration file2022-09-14T11:27:31+02:00gsellminor fixes in the main CMake configuration fileApple Clang doesn't support OpenMP: add check
If we compile with Clang, Fortran is not available (Flang is not yet production ready)Apple Clang doesn't support OpenMP: add check
If we compile with Clang, Fortran is not available (Flang is not yet production ready)2022.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/712Use keyword nullptr as null pointer constant2022-03-17T09:17:00+01:00ext-calvo_ppedro.calvo@ciemat.esUse keyword nullptr as null pointer constantSince C++11, `nullptr` provides a typesafe pointer value representing an empty (null) pointer, resolving ambiguous situations unlike the existing implementation dependent null pointer constant `NULL`. Therefore, `NULL` instances should b...Since C++11, `nullptr` provides a typesafe pointer value representing an empty (null) pointer, resolving ambiguous situations unlike the existing implementation dependent null pointer constant `NULL`. Therefore, `NULL` instances should be replaced it by `nullptr`2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/690Adding unit conversions to Physics.h2022-03-17T08:53:13+01:00carl_jAdding unit conversions to Physics.hI've updated the Physics.h to include a series of common unit conversions used throughout the code.
So far I've included:
- m <--> mm
- s <--> ns
- T <--> kG
- V <--> kV
- GeV/c^2 <--> kg
I've then used these conversions to replace ...I've updated the Physics.h to include a series of common unit conversions used throughout the code.
So far I've included:
- m <--> mm
- s <--> ns
- T <--> kG
- V <--> kV
- GeV/c^2 <--> kg
I've then used these conversions to replace the hard coded conversions in the following files:
- ParallelCyclotronTracker.cpp
- RK4.h
- OpalMultipoleT.cpp
I've linked [this issue](https://gitlab.psi.ch/OPAL/src/-/issues/357).
There's a bit more discussion on this in the comments there.2022.1carl_jext-rogers_ccarl_jhttps://gitlab.psi.ch/OPAL/src/-/issues/704Move unit conversions to separate file2022-03-17T08:53:13+01:00ext-calvo_ppedro.calvo@ciemat.esMove unit conversions to separate fileUnit conversions shouldn't be in the same file as physical entities, such as e.g. the speed of light (see OPAL/src#690). Instead move them to a new file and a new namespace.Unit conversions shouldn't be in the same file as physical entities, such as e.g. the speed of light (see OPAL/src#690). Instead move them to a new file and a new namespace.2022.1krauskraus