src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2020-12-01T15:09:02+01:00https://gitlab.psi.ch/OPAL/src/-/issues/535OPAL-FEL (MITHRA integration)2020-12-01T15:09:02+01:00albajacas_aarnau.albajacas@psi.chOPAL-FEL (MITHRA integration)### Summary
As part of my Master Thesis I am introducing an undulator/wiggler element in OPAL-t.
For this reason I have integrated the full-wave solver for undulators [MITHRA](https://github.com/aryafallahi/mithra).
This full-wave solv...### Summary
As part of my Master Thesis I am introducing an undulator/wiggler element in OPAL-t.
For this reason I have integrated the full-wave solver for undulators [MITHRA](https://github.com/aryafallahi/mithra).
This full-wave solver takes over when the bunch enters the undulator.
* [x] Add to [release notes](https://gitlab.psi.ch/OPAL/src/wikis/ReleaseNotes/ReleaseNotes)
* [x] Verify [coding style](https://gitlab.psi.ch/OPAL/src/wikis/For-Developers/CodingStyle)
* [x] Update documentation (OPAL/documentation/manual#38)
* [x] Add Regression Tests (OPAL/regression-tests#96)
* [x] Add module and flags to `NighltyBuild` (OPAL/regression-tests#99)
* [x] Resolve MR and all its issues (!361)OPAL 2021.1albajacas_aarnau.albajacas@psi.chalbajacas_aarnau.albajacas@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/459review FlexibleCollimator::isStopped() method in Classic2020-07-06T13:49:42+02:00gsellreview FlexibleCollimator::isStopped() method in Classic@kraus "The question is, where we should check whether a particle hits material at the center or at the end of a time step (ideally everywhere but too time consuming). It used to be at the end (before I implemented the configurable colli...@kraus "The question is, where we should check whether a particle hits material at the center or at the end of a time step (ideally everywhere but too time consuming). It used to be at the end (before I implemented the configurable collimator) and I changed it to the middle. The extra argument could probably be removed."
See discussion on MR !269 OPAL 2.4.0gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/157Cyclotron trim coil has discontinuous derivative2018-04-26T15:35:40+02:00snuverink_jjochem.snuverink@psi.chCyclotron trim coil has discontinuous derivativefollow up from issue #110 as discussed there.
![image](/uploads/b10d3189af1733a1fefaecdff531d423/image.png)
As can be seen in the figure the derivative of the B field is discontinuous in the middle of the trim coil. This comes by [cons...follow up from issue #110 as discussed there.
![image](/uploads/b10d3189af1733a1fefaecdff531d423/image.png)
As can be seen in the figure the derivative of the B field is discontinuous in the middle of the trim coil. This comes by [construction of the calculation](https://gitlab.psi.ch/OPAL/src/blob/9118749a7c5ffa2657ff9d11393f3b839171e2b2/src/Classic/AbsBeamline/Cyclotron.cpp#L118).
I think it would be good to:
* find out where the calculation comes from (see also comment https://gitlab.psi.ch/OPAL/src/issues/110#note_2391)
* get some measured trim coil profiles to see how important the effect could be.
Task list added 26 March (from https://gitlab.psi.ch/OPAL/src/issues/157#note_5500):
* [x] PSI-trim coils polynomial fit (with minimal order) (@frey_m)
* [x] OPAL trim coil polynomial input (@snuverink_j)
* [x] Comparison with current implementation for TC15, make polynomial input default (@frey_m, @snuverink_j)
* [x] Documentation
* [x] Regression/Unit testOPAL 2.0.0frey_msnuverink_jjochem.snuverink@psi.chfrey_m