src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2019-10-18T23:43:03+02:00https://gitlab.psi.ch/OPAL/src/-/issues/362Remove lPath_m variable and use spos_m instead for all flavours2019-10-18T23:43:03+02:00frey_mRemove lPath_m variable and use spos_m instead for all flavoursRemove `lPath_m` for OPAL-Cyc and use `spos_m` instead, as suggested in https://gitlab.psi.ch/OPAL/src/merge_requests/173#note_13240.Remove `lPath_m` for OPAL-Cyc and use `spos_m` instead, as suggested in https://gitlab.psi.ch/OPAL/src/merge_requests/173#note_13240.https://gitlab.psi.ch/OPAL/src/-/issues/361Apply commit also in master2019-09-28T15:09:42+02:00frey_mApply commit also in masterApply https://gitlab.psi.ch/OPAL/src/merge_requests/173/diffs?commit_id=8fca35f5ef24d868367aa3a48ca9a163548e0ee4 in the master too.Apply https://gitlab.psi.ch/OPAL/src/merge_requests/173/diffs?commit_id=8fca35f5ef24d868367aa3a48ca9a163548e0ee4 in the master too.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/360End position in findStartPosition wrong2019-09-30T14:16:19+02:00krausEnd position in findStartPosition wrongFrom [this line to line 1265](https://gitlab.psi.ch/OPAL/src/blob/OPAL-2.0/src/Algorithms/ParallelTTracker.cpp#L1258) there are two errors:
1. There is a sign error in line 1265
1. The push method of the Boris pusher pushes particles for...From [this line to line 1265](https://gitlab.psi.ch/OPAL/src/blob/OPAL-2.0/src/Algorithms/ParallelTTracker.cpp#L1258) there are two errors:
1. There is a sign error in line 1265
1. The push method of the Boris pusher pushes particles for a half time step. But we want it to push a full time step.
These bugs are fixed in the master with f5edc17e but needs to be fixed in OPAL-2.0.krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/358Cyclotron RestartTest-2 fails2019-09-13T09:52:35+02:00frey_mCyclotron RestartTest-2 failsThe regression test RestartTest-2 fails due to https://gitlab.psi.ch/OPAL/src/merge_requests/170The regression test RestartTest-2 fails due to https://gitlab.psi.ch/OPAL/src/merge_requests/170frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/356Cavity cuts lines2019-09-27T09:11:48+02:00frey_mCavity cuts lines### Summary
When a cavity is in the beam line it cuts the beam in longitudinal direction.
### Steps to reproduce
Run the Injector 2 with cavities in.
### What is the current *bug* behavior?
[injector_2](/uploads/925750a5a5194eb6a4...### Summary
When a cavity is in the beam line it cuts the beam in longitudinal direction.
### Steps to reproduce
Run the Injector 2 with cavities in.
### What is the current *bug* behavior?
[injector_2](/uploads/925750a5a5194eb6a495feb76c2ffbb0/injector_2.png)frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/355Wrong bunch information2019-09-27T09:12:54+02:00frey_mWrong bunch information### Summary
Wrong magnitude of `rmin` and `rmax` in case of OPAL-Cycl.
### Steps to reproduce
Run Injector-2 with OPAL-master or OPAL-1.6
### What is the current *bug* behavior?
`rmin` and `rmax` are scaled by a factor 1000 which ...### Summary
Wrong magnitude of `rmin` and `rmax` in case of OPAL-Cycl.
### Steps to reproduce
Run Injector-2 with OPAL-master or OPAL-1.6
### What is the current *bug* behavior?
`rmin` and `rmax` are scaled by a factor 1000 which yields:
```bash
OPAL> * *********************** Bunch information in local frame: ************************
OPAL> * rmax = ( 14.11518 , 22.17745 , 8.35929 ) [um]
OPAL> * rmin = ( -13.28184 , -20.78026 , -8.34465 ) [um]
OPAL> * rms beam size = ( 3.13787 , 4.45083 , 2.06234 ) [mm]
OPAL> * **********************************************************************************
```
```bash
OPAL> * *********************** Bunch information in global frame: ***********************
OPAL> * rmax = ( 355.14915 , 214.51694 , 8.35600 ) [um]
OPAL> * rmin = ( 323.97821 , 178.14940 , -8.34800 ) [um]
OPAL> * rms beam size = ( 3.55602 , 4.12442 , 2.06234 ) [mm]
OPAL> * **********************************************************************************
```
The bunch position in global frame is ```R = 392.01 mm``` which does not agree with the unit of `[um]`. The bunch
is also bigger!
### What is the expected *correct* behavior?
```bash
OPAL> * *********************** Bunch information in local frame: ************************
OPAL> * rmax = ( 14.11518 , 22.17745 , 8.35929 ) [mm]
OPAL> * rmin = ( -13.28184 , -20.78026 , -8.34465 ) [mm]
OPAL> * rms beam size = ( 3.13787 , 4.45083 , 2.06234 ) [mm]
OPAL> * **********************************************************************************
```
and
```bash
OPAL> * *********************** Bunch information in global frame: ***********************
OPAL> * rmax = ( 355.14915 , 214.51694 , 8.35600 ) [mm]
OPAL> * rmin = ( 323.97821 , 178.14940 , -8.34800 ) [mm]
OPAL> * rms beam size = ( 3.55602 , 4.12442 , 2.06234 ) [mm]
OPAL> * **********************************************************************************
```
### Possible fixes
Remove `lengthUnitConverter`
```C++
if (OpalData::getInstance()->isInOPALCyclMode()) {
lengthUnitConverter = 0.001;
pathLength = getLPath();
}
rmax_m *= lengthUnitConverter;
rmin_m *= lengthUnitConverter;
```frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/353Track back in time2019-09-07T18:55:00+02:00adelmannTrack back in time### Summary
We want to track a beam given beam back in time throughout the lattice. This can either be a followup track
or a given/generated distribution.
### Motivation
From measurements or intuition you construct a final phase spac...### Summary
We want to track a beam given beam back in time throughout the lattice. This can either be a followup track
or a given/generated distribution.
### Motivation
From measurements or intuition you construct a final phase space $`P_{final}`$. One can then ask the question how would you generate $`P_{initial}`$ and transport it. By tracking back (maybe using the optimiser) one can
hope to achieve such a goal.
### Approach (so far only for a straight machine ...)
1. The TRACK command is augment with Boolean **TRACKBACK=**
2. In **ParallelTTracker** the double member **arrowOfTime_m** is set to -1 in case of **TRACKBACK=TRUE**
3. In **ParallelTTracker::invertP** itsBunch->P[ ](2) *= arrowOfTime_m and
itsBunch_m->RefPartP_m *= arrowOfTime_m; is set [invertPz](http://amas.web.psi.ch/docs/opal/master-doxygen-new/d0/d39/a01138.html#ad0851e3c7c4947981014d3989560c7e5) (need to update Doxygen)
This is as far as I have implemented it, if I remember how to do the branch/merge stuff :) I will commit.
### To Do
0. All electrostatic elements do not need to be changed
1. Space charge needs to negate its action in all 3 dimensions.
3. RF
4. Make it more general i.e. 3. in Approach above
adelmannkrausadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/349Check that element length is long relative to a time step2020-08-18T09:46:53+02:00krausCheck that element length is long relative to a time stepIntroduce a check to OPAL-T that every element is sampled several times, e.g. 10 times. This is important for example for #37 (elements that don't support fringe fields) and #137 (Degraders with thin foils). Throw an exception with the...Introduce a check to OPAL-T that every element is sampled several times, e.g. 10 times. This is important for example for #37 (elements that don't support fringe fields) and #137 (Degraders with thin foils). Throw an exception with the information that the time step should be reduced.krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/348Failed regression tests after ElementPositionWriter MR2019-07-31T20:00:25+02:00snuverink_jjochem.snuverink@psi.chFailed regression tests after ElementPositionWriter MRAfter merging src!159, many regression tests fail: http://amas.web.psi.ch/opal/regressionTests/master/results_2019-07-30.xml
(previous: http://amas.web.psi.ch/opal/regressionTests/master/results_2019-07-27.xml)After merging src!159, many regression tests fail: http://amas.web.psi.ch/opal/regressionTests/master/results_2019-07-30.xml
(previous: http://amas.web.psi.ch/opal/regressionTests/master/results_2019-07-27.xml)krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/347Enabled warning overloaded-virtual for GCC2020-04-22T13:16:35+02:00gsellEnabled warning overloaded-virtual for GCCgsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/345remove obsolete build instructions and Makefile.def's2019-07-26T11:39:14+02:00gsellremove obsolete build instructions and Makefile.def'sAll the Makefile.def's are obsolete
- [x] done in OPAL-2.0
- [ ] done in masterAll the Makefile.def's are obsolete
- [x] done in OPAL-2.0
- [ ] done in mastergsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/344Probe Output2019-08-13T09:00:58+02:00frey_mProbe OutputThe probe files are written at the end of the OPAL-Cycl simulation. If a simulation is terminated earlier, e.g. due to incorrectly estimated time specifications, the information is lost. I think it would be better if probes output every ...The probe files are written at the end of the OPAL-Cycl simulation. If a simulation is terminated earlier, e.g. due to incorrectly estimated time specifications, the information is lost. I think it would be better if probes output every turn to the file like the H5 phase space dump.snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/343Distinguish bunches in probe2019-07-25T16:45:26+02:00frey_mDistinguish bunches in probe### Summary
It is currently not possible to distinguish single bunches in a probe in case of multi-bunch simulations. Although the ID and turn number are given it is somehow not possible to get a single bunch. Saving the bunch number (an...### Summary
It is currently not possible to distinguish single bunches in a probe in case of multi-bunch simulations. Although the ID and turn number are given it is somehow not possible to get a single bunch. Saving the bunch number (an attribute of `PartBunchBase`) will help to overcome this issue.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/342Wrong turn number at restart2019-07-24T11:09:46+02:00frey_mWrong turn number at restart### Summary
The turn number is initialized with a wrong value at restart. In OPAL-Cycl the turn number starts at 1 and is subtracted for print outs. However, at restart it is not taken care of this feature.
### Steps to reproduce
Ju...### Summary
The turn number is initialized with a wrong value at restart. In OPAL-Cycl the turn number starts at 1 and is subtracted for print outs. However, at restart it is not taken care of this feature.
### Steps to reproduce
Just restart a cyclotron simulation.
### Possible fix
As discussed with @snuverink\_j we need to increment the value by one at [line](https://gitlab.psi.ch/OPAL/src/blob/master/src/Algorithms/ParallelCyclotronTracker.cpp#L2848)
and subtract by one at [line](https://gitlab.psi.ch/OPAL/src/blob/master/src/Algorithms/ParallelCyclotronTracker.cpp#L2851).frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/341binning parameter not properly initialized in constructor2019-07-19T15:19:09+02:00frey_mbinning parameter not properly initialized in constructorIn the constructor of the `MultiBunchHandler` the variable `eta` is not assigned to the member variable `eta_m`.In the constructor of the `MultiBunchHandler` the variable `eta` is not assigned to the member variable `eta_m`.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/340review tools/BandRF/ascii2h5block_asgic.cpp2019-07-18T15:35:32+02:00gsellreview tools/BandRF/ascii2h5block_asgic.cpp* does not compile with current H5hut
* use std::cout for output not Ippl messages* does not compile with current H5hut
* use std::cout for output not Ippl messagesgsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/339Fix time in Leap-frog2019-07-18T09:33:02+02:00frey_mFix time in Leap-frogThe leap-frog stepper has code to be removed. The time is also doubled which is wrong.The leap-frog stepper has code to be removed. The time is also doubled which is wrong.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/338Cyclotron Regression tests fail / broken after !1292019-07-19T16:03:13+02:00frey_mCyclotron Regression tests fail / broken after !129The tests
* RestartTest-2 (broken)
* RestartTest-3 (broken)
* RestartTest-4 (broken)
* RingCyclotronMTS (failed)
do not work properlyThe tests
* RestartTest-2 (broken)
* RestartTest-3 (broken)
* RestartTest-4 (broken)
* RingCyclotronMTS (failed)
do not work properlyhttps://gitlab.psi.ch/OPAL/src/-/issues/337Sampler fails due to static variable in MueLuBottomSolver2020-07-14T10:29:45+02:00frey_mSampler fails due to static variable in MueLuBottomSolver### Summary
As in #336 the sampler crashes when dispatching new individuals after some finished.
### Steps to reproduce
Run the sampler with AMR Trilinos and the smoothed aggregation algebraic multigrid solver for the linear system o...### Summary
As in #336 the sampler crashes when dispatching new individuals after some finished.
### Steps to reproduce
Run the sampler with AMR Trilinos and the smoothed aggregation algebraic multigrid solver for the linear system of
equations.
### What is the current *bug* behavior?
The sampler crashes.
### What is the expected *correct* behavior?
The sampler runs smoothly.
### Possible fixes
Remove the static variable.frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/336Sampler fails due to static variable in SDDSWriters2020-07-14T10:41:25+02:00frey_mSampler fails due to static variable in SDDSWriters### Summary
Sampler crashed due to SDDSWriters.
### Steps to reproduce
Run the sampler.
### What is the current *bug* behavior?
The static variable `isFirst` of the new SDDSWriter interface (e.g.
[GridLBalWriter](https://gitlab.ps...### Summary
Sampler crashed due to SDDSWriters.
### Steps to reproduce
Run the sampler.
### What is the current *bug* behavior?
The static variable `isFirst` of the new SDDSWriter interface (e.g.
[GridLBalWriter](https://gitlab.psi.ch/OPAL/src/blob/master/src/Structure/GridLBalWriter.cpp#L16)) causes the sampler to crash with
```
Error{0}>
Error{0}> *** User error detected by function "SDDSColumnSet::addColumnValue"
Error{0}> column name 't' doesn't exists
Error{0}> column name 't' doesn't exists
```
### What is the expected *correct* behavior?
The sampler runs smoothly.
### Possible fixes
Making the variable a non-static `isFirst` a member of `SDDSWriter.h` fixes the problem.frey_mfrey_m