src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2021-06-10T18:10:55+02:00https://gitlab.psi.ch/OPAL/src/-/issues/66Reimplement boundary geometries, surface emission, multipacting etc in Parall...2021-06-10T18:10:55+02:00krausReimplement boundary geometries, surface emission, multipacting etc in ParallelTTrackerBoundary geometries, surface emission etc isn't ported from version 1.6 and in the near futur this won't be ported.Boundary geometries, surface emission etc isn't ported from version 1.6 and in the near futur this won't be ported.OPAL 1.9.xChuan WangChuan Wanghttps://gitlab.psi.ch/OPAL/src/-/issues/65Quadrupole components of dipoles is missing2021-06-10T18:10:26+02:00krausQuadrupole components of dipoles is missingK1 has been removed from RBEND/SBEND, reimplement it.K1 has been removed from RBEND/SBEND, reimplement it.OPAL 1.9.xhttps://gitlab.psi.ch/OPAL/src/-/issues/67Specification of distributions a la Elegant2020-04-22T11:38:48+02:00krausSpecification of distributions a la ElegantTo generate a distribution that corresponds to Elegant using betax, alphax, betay, alphay, nemittx, nemitty, sigma_s/sigma_t, p, sigma_dp.
J. KnedelTo generate a distribution that corresponds to Elegant using betax, alphax, betay, alphay, nemittx, nemitty, sigma_s/sigma_t, p, sigma_dp.
J. KnedelOPAL 1.9.xhttps://gitlab.psi.ch/OPAL/src/-/issues/68DumpEMFields option for OpalRing2018-09-19T12:59:30+02:00ext-rogers_cDumpEMFields option for OpalRingWould like to add a module to dump time varying magnetic fields for opalWould like to add a module to dump time varying magnetic fields for opalext-rogers_cext-rogers_chttps://gitlab.psi.ch/OPAL/src/-/issues/69VariableRFCavity is failing tests2017-06-17T20:38:35+02:00ext-rogers_cVariableRFCavity is failing testsTest incorrectly returns True during calls to apply (indicating particles "out of aperture" when they should not be)Test incorrectly returns True during calls to apply (indicating particles "out of aperture" when they should not be)ext-rogers_cext-rogers_chttps://gitlab.psi.ch/OPAL/src/-/issues/70Regressiontest RingCyclotronMatched failed2017-08-11T10:50:28+02:00adelmannRegressiontest RingCyclotronMatched failedRegressiontest RingCyclotronMatched is failing with OPAL-1.5.x
```
OPAL{0}> *** User error detected by function "ClosedOrbitFinder::findOrbit()"
OPAL{0}> *** in line 84 of file "RingCyclotronMatched.in" at end of statement:
OPAL{0}>...Regressiontest RingCyclotronMatched is failing with OPAL-1.5.x
```
OPAL{0}> *** User error detected by function "ClosedOrbitFinder::findOrbit()"
OPAL{0}> *** in line 84 of file "RingCyclotronMatched.in" at end of statement:
OPAL{0}> RUN,METHOD="CYCLOTRON-T",BEAM=BEAM1,FIELDSOLVER=FS1,DISTRIBUTION=DIST1;
OPAL{0}> p_{r}^2 > p^{2} (defined in Gordon paper) --> Square root of negative number.
```OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/71track-orbit of ID1 and ID2 OPAL-1.6 and master2021-06-10T18:49:09+02:00adelmanntrack-orbit of ID1 and ID2 OPAL-1.6 and masterIn data/track-orbit, the coordinates of ID1 and ID2 are **always** stored.
On the distribution command the user can set ID1 and ID2 by *hand*.
@rizzoglio_v : Please commentIn data/track-orbit, the coordinates of ID1 and ID2 are **always** stored.
On the distribution command the user can set ID1 and ID2 by *hand*.
@rizzoglio_v : Please commentadelmannadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/72Removal of data from a particle without reducing number of particles2017-07-24T10:29:37+02:00krausRemoval of data from a particle without reducing number of particlesThis leads to wrong results: https://gitlab.psi.ch/OPAL/src/blob/OPAL-1.6/src/Classic/Algorithms/PartBunch.cpp#L1930 . This is as if replacing position and momentum with zero.
Please remember to add the patch that solves this issue to ...This leads to wrong results: https://gitlab.psi.ch/OPAL/src/blob/OPAL-1.6/src/Classic/Algorithms/PartBunch.cpp#L1930 . This is as if replacing position and momentum with zero.
Please remember to add the patch that solves this issue to the master as well.adelmannadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/74Ring::getSectionsAt()2017-05-01T09:05:16+02:00snuverink_jjochem.snuverink@psi.chRing::getSectionsAt()From issue #62. The current implementation of Classic/AbsBeamline/Ring::getSectionsAt() is as follows:
```c++
std::vector<RingSection*> Ring::getSectionsAt(const Vector_t& r) {
return section_list_m;
double phi = atan2(r(1), -r(...From issue #62. The current implementation of Classic/AbsBeamline/Ring::getSectionsAt() is as follows:
```c++
std::vector<RingSection*> Ring::getSectionsAt(const Vector_t& r) {
return section_list_m;
double phi = atan2(r(1), -r(0))+Physics::pi;
// std::cerr << "GetSectionsAt " << phi << " " << phiStep_m << " " << int((phi)/phiStep_m) << " " << ringSections_m.size() << std::endl;
if (phi >= 2.*Physics::pi)
phi -= 2.*Physics::pi;
return ringSections_m[(phi)/phiStep_m];
}
```
The second part of the function is never reached due to the first return. From a coding point of view the second part might seem correct since otherwise the input is not used. If the first return is correct however, could the second part be removed or commented out? Assigning to @ext-rogers_c who [committed the code](https://gitlab.psi.ch/OPAL/src/blame/master/src/Classic/AbsBeamline/Ring.cpp).OPAL 1.5.3ext-rogers_cext-rogers_chttps://gitlab.psi.ch/OPAL/src/-/issues/75VERSION string2017-03-28T14:02:28+02:00adelmannVERSION stringcan someone explain why we write
OPTION, VERSION=10500;
and not
Option, VERSION="1.5.1"can someone explain why we write
OPTION, VERSION=10500;
and not
Option, VERSION="1.5.1"https://gitlab.psi.ch/OPAL/src/-/issues/76Make normalization of 3D fieldmaps optional2017-06-17T20:38:35+02:00krausMake normalization of 3D fieldmaps optionalCurrently the z-component of the (electric, if present) field of a 3D fieldmaps is normalized. The user should be able to disable this normalizaton to simulate e.g. transverse deflecting cavities.Currently the z-component of the (electric, if present) field of a 3D fieldmaps is normalized. The user should be able to disable this normalizaton to simulate e.g. transverse deflecting cavities.OPAL 2.0.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/77use-dks option2017-03-28T13:10:57+02:00Valeria Rizzogliouse-dks optionOn opalrunner, I load the opal-toolschain/1.6 and OPAL/1.5.1-20170217
```
> Currently Loaded Modulefiles:
> 1) gcc/5.4.0 4) hdf5/1.8.18 7) trilinos/12.10.1 10) OpenBLAS/0.2.19 13) opal-toolschain/1.6
>...On opalrunner, I load the opal-toolschain/1.6 and OPAL/1.5.1-20170217
```
> Currently Loaded Modulefiles:
> 1) gcc/5.4.0 4) hdf5/1.8.18 7) trilinos/12.10.1 10) OpenBLAS/0.2.19 13) opal-toolschain/1.6
> 2) openmpi/1.10.4 5) H5hut/2.0.0rc3 8) root/6.08.02 11) cuda/8.0.44 14) OPAL/1.5.1-20170217
> 3) boost/1.62.0 6) gsl/2.2.1 9) cmake/3.6.3 12) dks/1.0.1
```
then run opal with the --use-dks option: `opal --use-dks Input.in`
It seems that the GPU card is not detected (not sure if the IPPL message is correct).
```
Ippl> No GPU device detected! --use-dks flag will have no effect
> ____ _____ ___
> / __ \| __ \ /\ | |
> | | | | |__) / \ | |
> | | | | ___/ /\ \ | |
> | |__| | | / ____ \| |____
> \____/|_| /_/ \_\______|
OPAL>
OPAL> This is OPAL (Object Oriented Parallel Accelerator Library) Version 1.5.1
OPAL>
OPAL> (c) PSI, http://amas.web.psi.ch
OPAL>
OPAL> OPAL compiled with DKS (Dynamic Kernel Scheduler) Version 1.0.0
```OPAL 1.5.1https://gitlab.psi.ch/OPAL/src/-/issues/78Particle Matter interaction and Large Angle scattering2019-05-16T21:05:08+02:00adelmannParticle Matter interaction and Large Angle scatteringA 249 MeV proton beam is hitting a degrader
REAL WEDGE_HLEN=0.0197293;
REAL START = 0.02;
DEGPHYS_Wedge : SURFACEPHYSICS, TYPE="DEGRADER", MATERIAL="GraphiteR6710";
Wedge1: DEGRADER, L=WEDGE_HLEN, OUTFN="sWedge1.h5", SURFACEP...A 249 MeV proton beam is hitting a degrader
REAL WEDGE_HLEN=0.0197293;
REAL START = 0.02;
DEGPHYS_Wedge : SURFACEPHYSICS, TYPE="DEGRADER", MATERIAL="GraphiteR6710";
Wedge1: DEGRADER, L=WEDGE_HLEN, OUTFN="sWedge1.h5", SURFACEPHYSICS=DEGPHYS_Wedge, ELEMEDGE=START;
The claim is that the following transverse real space
![image](/uploads/96f74bd4cd02104fb0f45ba275702de5/image.png)
and transverse momenta space
![image](/uploads/4a30f2ebddb24ba7bc1e7da81e087bb9/image.png)
is **not** correct.
Switching off the large angle scattering (http://amas.web.psi.ch/docs/opal/opal_user_guide.pdf 18.2.2) the "halo" is disappearing, as shown
by the red dots in the following picture:
![image](/uploads/ea17023a70f261b39db30854795d1485/image.png)
Switch off == omment out: https://gitlab.psi.ch/OPAL/src/blob/master/src/Classic/Solvers/CollimatorPhysics.cpp#L777 and
https://gitlab.psi.ch/OPAL/src/blob/master/src/Classic/Solvers/CollimatorPhysics.cpp#L746
Now we can enable/disable Rutherford scattering
`DEGPHYS_Wedge : SURFACEPHYSICS, TYPE="DEGRADER", MATERIAL="GraphiteR6710", ENABLERUTHERFORD=TRUE;
`
Default is **ENABLED**
Be aware of the fact this inout file runs only with OPAL-1.6 (git checkout OPAL-1.6)
[sDegrader_70.in](/uploads/8ef0732890ee80d73567650e8e4f810a/sDegrader_70.in)
OPAL 1.9.xbaumgartenchristian.baumgarten@psi.chbaumgartenchristian.baumgarten@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/79ArbitraryDomain::globalToLocalQuaternion_m also defined in its parent class '...2017-05-01T09:05:17+02:00snuverink_jjochem.snuverink@psi.chArbitraryDomain::globalToLocalQuaternion_m also defined in its parent class 'IrregularDomainFrom issue #62. `[src/Solvers/ArbitraryDomain.h:84] -> [src/Solvers/IrregularDomain.h:123]: (warning) The class 'ArbitraryDomain' defines member variable with name 'globalToLocalQuaternion_m' also defined in its parent class 'IrregularDo...From issue #62. `[src/Solvers/ArbitraryDomain.h:84] -> [src/Solvers/IrregularDomain.h:123]: (warning) The class 'ArbitraryDomain' defines member variable with name 'globalToLocalQuaternion_m' also defined in its parent class 'IrregularDomain'.`
Shadowing members is very error-prone and was probably not intended.
A quick look at the code seems to show that the derived ArbitraryDomain uses its globalToLocalQuaternion_m as a read-only copy of its parent member. So ArbitraryDomain::globalToLocalQuaternion_m can be safely substituted for a local variable since there is a public getter method (and even the actual parent member is directly accessible (protected)).OPAL 1.5.3adelmannadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/81Segfault within Surfacephysics2017-06-17T20:38:35+02:00krausSegfault within SurfacephysicsWith input file [Degrader_70.in](/uploads/4971dc04fcdf6cbee66b92aea9f83832/Degrader_70.in) I got a segmentation fault. Suddenly an incredibly large number of additional particles were generated, then OPAL crashed. Couldn't reproduce it a...With input file [Degrader_70.in](/uploads/4971dc04fcdf6cbee66b92aea9f83832/Degrader_70.in) I got a segmentation fault. Suddenly an incredibly large number of additional particles were generated, then OPAL crashed. Couldn't reproduce it anymore, but something isn't correct.OPAL 2.0.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/82IPPL extra message error2017-12-21T12:02:10+01:00frey_mIPPL extra message errorOPAL crashes for > 16 cores (but works with #cores = 4) with the error message
>>>
Error{0}> get_iter(): no more items in Message
Error{0}> reduce: mismatched element count in vector reduction.
Warning{0}> CommMPI: Found extra message...OPAL crashes for > 16 cores (but works with #cores = 4) with the error message
>>>
Error{0}> get_iter(): no more items in Message
Error{0}> reduce: mismatched element count in vector reduction.
Warning{0}> CommMPI: Found extra message from node 11, tag 10218: msg = Message contains 2 items (0 removed). Contents:
Warning{0}> Item 0: 1 elements, 1 bytes total, needDelete = 0
Warning{0}> Item 1: 3 elements, 24 bytes total, needDelete = 0
>>>
in case of serial x and y directions (i.e. PARFFTX=false, PARFFTY=false) and parallel z direction (i.e. PARFFTT=true). The simulation that was ran is [psiring.in](/uploads/06e3f41f765be149e96b56bd6b277485/psiring.in). The fieldmaps can be found in the repository [AMAS-BDModels / PSI-Ring](https://gitlab.psi.ch/AMAS-BDModels/PSI-Ring/tree/master/Fieldmaps). Following modules were used for running on Merlin:
>>>
module use unstable
module add gcc/5.4.0
module add openmpi/1.10.4
module add hdf5/1.8.18
module add H5hut/2.0.0rc3
module add trilinos/12.10.1
module add gsl/2.2.1
module add boost/1.62.0
>>>
When changing to parallel x, y and serial z, i.e. PARFFTX=true, PARFFTY=true and PARFFTT=false) no error occurs.OPAL 1.9.xfrey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/83Bethe-Bloch threshold2021-01-30T19:16:00+01:00adelmannBethe-Bloch thresholdAllow the user to specify when a particle is dead (in the Bethe-Bloch) calculationAllow the user to specify when a particle is dead (in the Bethe-Bloch) calculationOPAL 2021.1adelmannext-calvo_ppedro.calvo@ciemat.esadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/84Cyclotron (COMET) does not read RFMAPFN's2020-12-07T13:27:04+01:00adelmannCyclotron (COMET) does not read RFMAPFN's```
COMET: Cyclotron, TYPE="BANDRF", CYHARMON= 2, PHIINIT= -71.649, PRINIT= pr0, RINIT= r0 , SYMMETRY= 1.0,
FMAPFN="BMap_Christian.txt",
RFPHI= {hfphi0/180*pi,hfphi0/180*pi,hfphi0/180*pi,hfphi0/180...```
COMET: Cyclotron, TYPE="BANDRF", CYHARMON= 2, PHIINIT= -71.649, PRINIT= pr0, RINIT= r0 , SYMMETRY= 1.0,
FMAPFN="BMap_Christian.txt",
RFPHI= {hfphi0/180*pi,hfphi0/180*pi,hfphi0/180*pi,hfphi0/180*pi,0.5*pi,0.5*pi,0.5*pi,0.5*pi},
RFFREQ= {frequency,frequency,frequency,frequency,0,0,0,0},
RFMAPFN={"ChimneyEB.h5part","PullerEB.h5part","M77EB.h5part","COMETRF_x850EBc.h5part",
"ehfieldTR.h5part","ehfieldTR2.h5part","ehfieldTR3.h5part","ehfieldTR4.h5part"},
ESCALE={0.84,0.84,0.84,0.4395,-4.5,+6.5,+4.5,-6.5},
MAXZ=15, MINZ=-15, MINR=0, MAXR= 881.1,
SUPERPOSE={false,false,false,false,true,true,true,true};
```
The full set of inputfiles is to large. All inputfiles can be found at: merlinl1.psi.ch:~adelmann/COMET/1.5.1-20170217OPAL 2021.1adelmannext-calvo_ppedro.calvo@ciemat.esadelmannhttps://gitlab.psi.ch/OPAL/src/-/issues/85Error in compiling OPAL-1.6 with -DENABLE_DKS=12017-06-17T20:38:34+02:00Valeria RizzoglioError in compiling OPAL-1.6 with -DENABLE_DKS=1I have the following modules loaded:
```
Currently Loaded Modulefiles:
1) gcc/5.4.0 4) hdf5/1.8.18 7) trilinos/12.10.1 10) OpenBLAS/0.2.19 13) opal-toolschain/1.6
2) openmpi/1.10.4 5) H5hut/2.0...I have the following modules loaded:
```
Currently Loaded Modulefiles:
1) gcc/5.4.0 4) hdf5/1.8.18 7) trilinos/12.10.1 10) OpenBLAS/0.2.19 13) opal-toolschain/1.6
2) openmpi/1.10.4 5) H5hut/2.0.0rc3 8) root/6.08.02 11) cuda/8.0.44
3) boost/1.62.0 6) gsl/2.2.1 9) cmake/3.6.3 12) dks/1.0.1
```
and I got the following error message:
```
/home/scratch/opal/src/src/Classic/Solvers/CollimatorPhysics.cpp: In member function ‘void CollimatorPhysics::setupCollimatorDKS(PartBunch&, Degrader*, size_t)’:
/home/scratch/opal/src/src/Classic/Solvers/CollimatorPhysics.cpp:1094:52: error: no matching function for call to ‘DKSBase::callInitRandoms(int&, int&)’
dksbase.callInitRandoms(size, Options::seed);
^
In file included from /home/scratch/opal/src/ippl/src/Utility/IpplInfo.h:59:0,
from /home/scratch/opal/src/ippl/src/Message/Message.hpp:29,
from /home/scratch/opal/src/ippl/src/Message/Message.h:618,
from /home/scratch/opal/src/ippl/src/AppTypes/Vektor.h:16,
from /home/scratch/opal/src/src/Classic/Algorithms/Vektor.h:6,
from /home/scratch/opal/src/src/Classic/Solvers/CollimatorPhysics.hh:13,
from /home/scratch/opal/src/src/Classic/Solvers/CollimatorPhysics.cpp:9:
/opt/psi/MPI/dks/1.0.1/openmpi/1.10.4/gcc/5.4.0/include/DKSBase.h:1077:7: note: candidate: int DKSBase::callInitRandoms(int)
int callInitRandoms(int size);
^
/opt/psi/MPI/dks/1.0.1/openmpi/1.10.4/gcc/5.4.0/include/DKSBase.h:1077:7: note: candidate expects 1 argument, 2 provided
[ 60%] Building CXX object src/CMakeFiles/OPALib.dir/Classic/Utilities/DivideError.cpp.o
```OPAL 1.6.0https://gitlab.psi.ch/OPAL/src/-/issues/86OPAL-1.6 check DKS version used to compile2017-06-17T20:38:34+02:00Uldis LocansOPAL-1.6 check DKS version used to compileOPAL-1.6 does not check which DKS version is used so compilation errors are possible due to the wrong versionsOPAL-1.6 does not check which DKS version is used so compilation errors are possible due to the wrong versionsOPAL 1.6.0