src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2020-07-15T16:53:42+02:00https://gitlab.psi.ch/OPAL/src/-/issues/285Matched Distribution: Not matched?2020-07-15T16:53:42+02:00frey_mMatched Distribution: Not matched?@cortes_c experienced that a particle tracking with a matched distribution doesn't remain matched after 1 turn. @baumgarten suggested to check the orientation of the integration.
Corresponding branch: https://gitlab.psi.ch/OPAL/src/tree...@cortes_c experienced that a particle tracking with a matched distribution doesn't remain matched after 1 turn. @baumgarten suggested to check the orientation of the integration.
Corresponding branch: https://gitlab.psi.ch/OPAL/src/tree/matched-gauss-fixes **(deleted)**
CC: @snuverink_j @cortes_c
- [x] fix crash of regression test (see https://gitlab.psi.ch/OPAL/src/merge_requests/364)
- [x] ~~check unit~~ [**Edit:** Checked with !393]
- [x] check why not matched (see !393)
- [x] update regression test due to changes of !393 (see https://gitlab.psi.ch/OPAL/regression-tests/merge_requests/20)OPAL 2.4.0frey_mfrey_m2020-07-24https://gitlab.psi.ch/OPAL/src/-/issues/244Linear transfer maps in SigmaGenerator.h2020-04-07T17:11:06+02:00cortes_cLinear transfer maps in SigmaGenerator.hThe linear transfer maps used in SigmaGenerator.h delivered from the MapGenerator.h class does not agree with the theoretical expectation. Please fix.The linear transfer maps used in SigmaGenerator.h delivered from the MapGenerator.h class does not agree with the theoretical expectation. Please fix.OPAL 2.4.0frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/156The Degrader-1 test yields different results when dks is enabled2020-05-01T10:10:14+02:00krausThe Degrader-1 test yields different results when dks is enabledrms x and rms y seem to be fine, only the energy is affected. On a first inspection of the DKS code (CudaCollimatorPhysics.cu) I couldn't find anything obvious. I have no expertise nor the hardware to debug code for cuda.rms x and rms y seem to be fine, only the energy is affected. On a first inspection of the DKS code (CudaCollimatorPhysics.cu) I couldn't find anything obvious. I have no expertise nor the hardware to debug code for cuda.OPAL 2.4.0locans_ulocans_uhttps://gitlab.psi.ch/OPAL/src/-/issues/579Add option to Source element to make it transparent to backtracking particles.2020-07-23T20:54:11+02:00krausAdd option to Source element to make it transparent to backtracking particles.Add option TRANSPARENT which regulates whether backtracking particles are stopped.Add option TRANSPARENT which regulates whether backtracking particles are stopped.OPAL 2.4.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/578Place elements relative to origin and orientation of beamline2020-07-24T12:51:42+02:00krausPlace elements relative to origin and orientation of beamlineUntil now, elements that are positioned with X, Y, Z instead of ELEMEDGE were positioned absolutely in the laboratory coordinate system. It would be much more practical if these elements were placed relative to the beamline.
As far as I...Until now, elements that are positioned with X, Y, Z instead of ELEMEDGE were positioned absolutely in the laboratory coordinate system. It would be much more practical if these elements were placed relative to the beamline.
As far as I know positioning with X, Y, Z isn't used by anyone yet.OPAL 2.4.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/470New multiGauss distribution2020-02-20T10:32:48+01:00albajacas_aarnau.albajacas@psi.chNew multiGauss distribution### Summary
In the cathode at the Argonne Wakefield Accelerator they have the ability to produce microbunched electron bunches, thanks to a laser beam which has a train of Gaussian pulses.
[Temporal Laser Pulse Shaping for RF Photocatho...### Summary
In the cathode at the Argonne Wakefield Accelerator they have the ability to produce microbunched electron bunches, thanks to a laser beam which has a train of Gaussian pulses.
[Temporal Laser Pulse Shaping for RF Photocathode Guns](https://aip.scitation.org/doi/10.1063/1.3080991)
At the moment there is no OPAL distribution to reproduce this.
Here is an example with 4 Gaussian microbunches separated (peak-to-peak) by 1.26 mm:
```
Dist: DISTRIBUTION, TYPE = MULTIGAUSS,
SIGMAPX = 1e-2, SIGMAPY = 1e-2, SIGMAPZ = 1e-2, // In units of betaGamma
CUTOFFPX = 4.0, CUTOFFPY = 4.0, CUTOFFPZ = 4.0, // In units of SIGMAP
SIGMAR = 340e-6,
SIGMAZ = .9e-3 / 2.355, // FWHM = 2.355 * sigma
CUTOFFLONG = 4.0, // In units of SIGZ
SEPPEAKS = 1.26e-3,
NPEAKS = 4,
EMITTED = FALSE;
```
This is what it looks like:
![distroInject](/uploads/65acbe6003cd1c8336272d98e3ddc5a8/distroInject.png)
In the case where the bunch is emitted, SIGMAPX/Y/Z and CUTOFFPX/Y/Z are omitted, and SIGMAZ and SEPPEAKS are to be given in seconds.OPAL 2.4.0albajacas_aarnau.albajacas@psi.chalbajacas_aarnau.albajacas@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/239Remove requirement of data file for SAMPLER and OPTIMIZER2020-06-22T09:42:35+02:00adelmannRemove requirement of data file for SAMPLER and OPTIMIZERWe still use the runOPAL.py scheme with template / data file. However the design variables could be easily looked up in the dictionary or we invent new types: DvarReal etc.
[Edit: this has been moved to a separate issue, see #249! If we...We still use the runOPAL.py scheme with template / data file. However the design variables could be easily looked up in the dictionary or we invent new types: DvarReal etc.
[Edit: this has been moved to a separate issue, see #249! If we could define quantities of interest (a la optimizer) and write them to the json file lengthly post processing would be avoided.]
Edit:
- [x] remove the need for a data file (!288)
- [x] write a json file containing the values of the DVARs and objectives (#249)OPAL 2.4.0frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/602Update Doxygen main page in OPAL 2.42020-08-20T08:46:30+02:00gsellUpdate Doxygen main page in OPAL 2.4Abstract and author list of Doxygen main page needs reviewAbstract and author list of Doxygen main page needs reviewOPAL 2.4.0gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/599OPAL-2.4 compile error in unit tests2020-08-14T11:05:46+02:00frey_mOPAL-2.4 compile error in unit testsFix error in https://gitlab.psi.ch/OPAL/src/-/issues/598 for OPAL-2.4.Fix error in https://gitlab.psi.ch/OPAL/src/-/issues/598 for OPAL-2.4.OPAL 2.4.0frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/595remove OPAL_FEL option from CMake configuration2020-08-10T16:03:42+02:00gsellremove OPAL_FEL option from CMake configurationOPAL_FEL is not available. This should be removed from the CMake configuration and not exposed to the user.OPAL_FEL is not available. This should be removed from the CMake configuration and not exposed to the user.OPAL 2.4.0gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/590Regression test AWAGun-Trackback-1 fails2020-08-05T10:39:10+02:00snuverink_jjochem.snuverink@psi.chRegression test AWAGun-Trackback-1 failsThe `AWAGun-Trackback-1` regression test fails (by a small difference in energy):
http://amas.web.psi.ch/opal/regressionTests/master/results_2020-08-04.xml
```
rms_x avg 1e-05 5.111029460895303e-08
rms_y avg 1e-05 5.1156002121029413e-...The `AWAGun-Trackback-1` regression test fails (by a small difference in energy):
http://amas.web.psi.ch/opal/regressionTests/master/results_2020-08-04.xml
```
rms_x avg 1e-05 5.111029460895303e-08
rms_y avg 1e-05 5.1156002121029413e-08
rms_s avg 1e-05 5.884942548195067e-07
emit_x avg 1e-05 1.1452361821547997e-09
emit_y avg 1e-05 1.1531791285653276e-09
emit_s avg 1e-05 2.079697542474211e-09
energy avg 1e-05 0.0003093416526873199
```
![image](/uploads/f71f3e7dbbc1424cc1868ba828696058/image.png)
This is likely due to !413 and !414, so probably also on 2.4.OPAL 2.4.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/581OPAL 2.4 release2020-09-03T10:43:43+02:00gsellOPAL 2.4 release# ToDo List for OPAL release 2.4.0
**source code and binary**
* [x] create branch 2.4
* [x] update version string in Doxyfile
* [x] update the version string in CMakeLists.txt and commit
* [x] tag version 2.4.0
* [x] upload so...# ToDo List for OPAL release 2.4.0
**source code and binary**
* [x] create branch 2.4
* [x] update version string in Doxyfile
* [x] update the version string in CMakeLists.txt and commit
* [x] tag version 2.4.0
* [x] upload source tar-ball to `/afs/psi.ch/project/amas/webhosting/Downloads/OPAL/src`
* [x] compile new binary for Linux
* GCC 8.4, Open MPI 3.1.6
* `cmake -DENABLE_AMR=ON -DENABLE_AMR_MG_SOLVER=ON -DENABLE_BANDRF=ON -DENABLE_SAAMG_SOLVER=ON -DCMAKE_BUILD_TYPE=Release`
* [x] upload Linux binary package to `/afs/psi.ch/project/amas/webhosting/Downloads/OPAL/package/`
* [x] compile new binary for macOS
* [x] upload macOS binary package to `/afs/psi.ch/project/amas/webhosting/Downloads/OPAL/package/`
**manual/documentation**
* [x] setup a new branch `Manual-2.4` for the new version of the manual
* [x] fix version, branches and links in `Manual.attributes`.
* [x] clone repository into `/afs/psi.ch/project/amas/webhostin/opal/Documentation/2.4` and checkout branch `Manual-2.4`
* [x] add links to the binaries in the wiki
* [x] update https://gitlab.psi.ch/OPAL/src/wikis/For-Developers/Compile-OPAL
* [x] compile the change log/release notes and publish it in the wiki: https://gitlab.psi.ch/OPAL/src/wikis/ReleaseNotes
* [x] review the file `src/addToDoxygenMainPage.h`
* [x] build Doxygen documentation for OPAL 2.4
* [x] update https://gitlab.psi.ch/OPAL/src/wikis/home
* [x] update https://gitlab.psi.ch/OPAL/src/wikis/regression-tests
**tracker**
* [x] create new label `OPAL 2.4`
* [x] update labels and milestones in issues
**regression-tests**
* [x] create new branch 2.4
* [x] setup the regression-tests to run the new version on opalrunner.psi.ch
**varia**
* [x] PSI module
* [x] write e-mail to mailing listOPAL 2.4.0gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/565Code duplication in Domains2020-07-24T12:51:42+02:00frey_mCode duplication in DomainsThe following discussion from !372 should be addressed:
- [x] @snuverink_j started a [discussion](https://gitlab.psi.ch/OPAL/src/merge_requests/372#note_24147): (+3 comments)
> The first part of this function is now duplicated thr...The following discussion from !372 should be addressed:
- [x] @snuverink_j started a [discussion](https://gitlab.psi.ch/OPAL/src/merge_requests/372#note_24147): (+3 comments)
> The first part of this function is now duplicated three times: once here, once in `BoxCornerDomain::constantInterpolation` and once in `EllipticDomain::constantInterpolation`.
>
> I think a helper method in the base class would be good to reduce the duplication.OPAL 2.4.0frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/561run.time of GreenWakeFunctionTest unit-test2020-07-08T11:20:09+02:00gsellrun.time of GreenWakeFunctionTest unit-testThe `GreenWakeFunctionTest` runs longer than 240 seconds on my (pretty new Macbook). This is a bit long for a unit-test. Would it be possible to make this test faster?The `GreenWakeFunctionTest` runs longer than 240 seconds on my (pretty new Macbook). This is a bit long for a unit-test. Would it be possible to make this test faster?OPAL 2.4.0snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/560`Util/Util.cpp` always compiled (Follow-up from "Resolve "better solution to ...2020-07-07T13:37:48+02:00snuverink_jjochem.snuverink@psi.ch`Util/Util.cpp` always compiled (Follow-up from "Resolve "better solution to create/update src/OPALrevision.h")The following discussion from !381 should be addressed:
- [x] @kraus started a [discussion](https://gitlab.psi.ch/OPAL/src/merge_requests/381#note_23778): (+1 comment)
> The downside of the current method is that `Util/Util.cpp` i...The following discussion from !381 should be addressed:
- [x] @kraus started a [discussion](https://gitlab.psi.ch/OPAL/src/merge_requests/381#note_23778): (+1 comment)
> The downside of the current method is that `Util/Util.cpp` is compiled every time `make` is called. It is compiled even if there are no other files that have to be compiled, e.g. when calling `make` twice without changing anything inbetween.OPAL 2.4.0snuverink_jjochem.snuverink@psi.chsnuverink_jjochem.snuverink@psi.chhttps://gitlab.psi.ch/OPAL/src/-/issues/554Unused classes in src2020-07-21T10:31:37+02:00ext-calvo_ppedro.calvo@ciemat.esUnused classes in srcThere are some unused classes in opal that should be removed.
| class | @kraus | @adelmann | @frey\_m | @snuverink\_j | @ext\-rogers\_c |
| ------ | ---- | ---- | ---- | ---- | ---- |
| Alg...There are some unused classes in opal that should be removed.
| class | @kraus | @adelmann | @frey\_m | @snuverink\_j | @ext\-rogers\_c |
| ------ | ---- | ---- | ---- | ---- | ---- |
| Algorithms/ParallelTTracker | :x: | :x: | :x: | :x: | :x: |
| AbstractObjects/Editor | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/AbstractMapper | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/LinearMapper | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/Mapper | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/rbendmap | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/Surveyor | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/ThinMapper | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/ThinTracker | :+1: | :+1: | :+1: | :+1: | :+1: |
| BasicActions/Dump | :+1: | :+1: | :+1: | :+1: | :+1: |
| BasicActions/Save | :+1: | :+1: | :+1: | :+1: | :+1: |
| BasicActions/Show | :+1: | :+1: | :+1: | :+1: | :+1: |
| BasicActions/What | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineGeometry/OffsetGeometry | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineGeometry/SRotatedGeometry | :+1: | :+1: | :+1: | :+1: | :+1: |
| Construction/ElementFactory | :+1: | :+1: | :+1: | :+1: | :+1: |
| Construction/Factory | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/AttCell | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalHMonitor | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalVMonitor | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalInstrument | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalParallelPlate | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalPatch | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalSplineTimeDependence | :x: | :x: | :+1: | :+1: | :x: |
| Elements/OpalSRot | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalYRot | :+1: | :+1: | :+1: | :+1: | :+1: |
| Elements/OpalSeparator | :+1: | :+1: | :+1: | :+1: | :+1: |
| Fields/Interpolation/ConstEField | :+1: | :+1: | :+1: | :+1: | :+1: |
| Fields/Interpolation/EDipoleField | :+1: | :+1: | :+1: | :+1: | :+1: |
| Fields/Interpolation/TwoDGrid | :x: | :x: | :+1: | :+1: | :x: |
| FixedAlgebra/FNormalForm | :+1: | :+1: | :+1: | :+1: | :+1: |
| FixedAlgebra/FStaticFP | :+1: | :+1: | :+1: | :+1: | :+1: |
| FixedAlgebra/LinearMath | :+1: | :+1: | :+1: | :+1: | :+1: |
| FixedAlgebra/TransportMath | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/AttList | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/AttWriter | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/Flatten | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/Insertion | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/Period | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/Survey | :+1: | :+1: | :+1: | :+1: | :+1: |
| Tables/Twiss | :+1: | :+1: | :+1: | :+1: | :+1: |
| Track/TrackStart | :+1: | :+1: | :+1: | :+1: | :+1: |
| Track/TrackSave | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/BeamBeam | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/Diagnostic | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/ElementImage | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/Integrator | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/Lambertson | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/ParallelPlate | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/Patch | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/RFQuadrupole | :+1: | :+1: | :+1: | :+1: | :+1: |
| AbsBeamline/Separator | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/NilTracker | :+1: | :+1: | :+1: | :+1: | :+1: |
| Algorithms/ThickMapper | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineCore/BeamBeamRep | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineCore/ParallelPlateRep | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineCore/PatchRep | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineCore/SeparatorRep | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineCore/XMonitorRep | :+1: | :+1: | :+1: | :+1: | :+1: |
| BeamlineCore/YMonitorRep | :+1: | :+1: | :+1: | :+1: | :+1: |
| Expressions/ARefAttr | :+1: | :+1: | :+1: | :+1: | :+1: |
Please have a look at these files and please give your ok, if the files can be deleted.OPAL 2.4.0frey_mfrey_mhttps://gitlab.psi.ch/OPAL/src/-/issues/553remove particle type unused2020-06-11T00:15:09+02:00ext-calvo_ppedro.calvo@ciemat.esremove particle type unusedSince !81 and !286, `ParticleType::FIELDEMISSION` is not used. I propose to remove itSince !81 and !286, `ParticleType::FIELDEMISSION` is not used. I propose to remove itOPAL 2.4.0ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/551remove unused code for secondary emission2020-06-09T17:07:06+02:00gsellremove unused code for secondary emissionThe secondary emission code is not used, not supported and should be removed.The secondary emission code is not used, not supported and should be removed.OPAL 2.4.0gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/548Remove MapIntegrator and TrackIntegrator classes2020-07-06T13:48:31+02:00krausRemove MapIntegrator and TrackIntegrator classesThe class `MapIntegrator` is the only derived class of `TrackIntegrator` and both have the pure virtual function `clone`. I don't see how they should be used if no class is derived that implements this function.The class `MapIntegrator` is the only derived class of `TrackIntegrator` and both have the pure virtual function `clone`. I don't see how they should be used if no class is derived that implements this function.OPAL 2.4.0krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/543SAAMG: Enable RectangularDomain2020-07-21T13:53:57+02:00frey_mSAAMG: Enable RectangularDomainThe rectangular domain is currently not added to the SAAMG.The rectangular domain is currently not added to the SAAMG.OPAL 2.4.0frey_mfrey_m