src issueshttps://gitlab.psi.ch/OPAL/src/-/issues2022-01-17T08:08:55+01:00https://gitlab.psi.ch/OPAL/src/-/issues/699Redefine heavy ion beams2022-01-17T08:08:55+01:00ext-calvo_ppedro.calvo@ciemat.esRedefine heavy ion beamsThe following discussion from !548 should be addressed:
- @snuverink_j started a [discussion](https://gitlab.psi.ch/OPAL/src/-/merge_requests/548#note_35297): (+9 comments)
> Is there maybe a reference why we use these particle ch...The following discussion from !548 should be addressed:
- @snuverink_j started a [discussion](https://gitlab.psi.ch/OPAL/src/-/merge_requests/548#note_35297): (+9 comments)
> Is there maybe a reference why we use these particle charges for Xenon and Uranium? I think it would be good to add this here.
Beam particle definition for heavy ions is not well determined. Uranium and xenon beams can have different ionization states, but currently OPAL only considers a given charge state. The definition of these particles must be reviewed, establishing univocal values for the mass and the charge states as `PARTICLE` types in the `BEAM` command. If any user wants to simulate these type of ions with a different ionization state or other isotope kind, it can be done by means of the attributes `MASS` and `CHARGE`. In addition, the documentation in the Manual must be modified (see OPAL/documentation/manual#70).2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/698Longitudinal positions in temporal monitor wrong2022-01-31T16:12:52+01:00krausLongitudinal positions in temporal monitor wrongWhen one compares the mean longitudinal positions of the bunch relative to the reference particle in temporal monitor and the phase space file then one observes that the values dont agree very well. In the h5 file the values are continuo...When one compares the mean longitudinal positions of the bunch relative to the reference particle in temporal monitor and the phase space file then one observes that the values dont agree very well. In the h5 file the values are continuous whereas in the monitor file the values are randomly (?) shifted, [see here](/uploads/58fd2be9e7eb79e6659e43c94134ca9c/compare_mean_values_of_monitors_and_stat.pdf).2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/697Fix elementTypeToString map2021-12-12T23:23:05+01:00ext-calvo_ppedro.calvo@ciemat.esFix elementTypeToString mapThe map `elementTypeToString_s` introduce in the implementation of OPAL/src#694 contains some bugs that have broken [UndulatorTest](http://amas.web.psi.ch/opal/unitTests/master/results_2021-11-30_10-49.xml) and [VFFA-1 regression test](h...The map `elementTypeToString_s` introduce in the implementation of OPAL/src#694 contains some bugs that have broken [UndulatorTest](http://amas.web.psi.ch/opal/unitTests/master/results_2021-11-30_10-49.xml) and [VFFA-1 regression test](http://amas.web.psi.ch/opal/regressionTests/master/results_2021-11-30_10-49.xml):
- Element string names must be lowercase
- `Ring` element is missing2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/696Some regression tests fails2021-11-16T19:42:15+01:00ext-calvo_ppedro.calvo@ciemat.esSome regression tests failsAfter implementing OPAL/src!552, some regression tests [fails](http://amas.web.psi.ch/opal/regressionTests/master/results_2021-11-16_10-49.xml) due to a bad unit conversion perform in `OpalCavity.cpp` (line 110): the correct conversion i...After implementing OPAL/src!552, some regression tests [fails](http://amas.web.psi.ch/opal/regressionTests/master/results_2021-11-16_10-49.xml) due to a bad unit conversion perform in `OpalCavity.cpp` (line 110): the correct conversion is `MHz2Hz`2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/695Compilation broken2021-11-16T08:58:57+01:00ext-calvo_ppedro.calvo@ciemat.esCompilation brokenCompilation with AMR solver was broken (see [link](http://amas.web.psi.ch/opal/master/output/2021-11-15_10-49.txt)) due to a missing bracket in Line 361 of `AmrBoxLib.cpp` after merging OPAL/src!552Compilation with AMR solver was broken (see [link](http://amas.web.psi.ch/opal/master/output/2021-11-15_10-49.txt)) due to a missing bracket in Line 361 of `AmrBoxLib.cpp` after merging OPAL/src!5522022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/694Replace plain enum by enum class2023-08-28T12:37:41+02:00ext-calvo_ppedro.calvo@ciemat.esReplace plain enum by enum classSince C++11 scoped enumerations (`enum class`) overcomes a lot of the drawbacks of classical enumerations. Some plain enum may be substituted throughout the code, such as e.g. `ElementType` or `DistrTypeT`.Since C++11 scoped enumerations (`enum class`) overcomes a lot of the drawbacks of classical enumerations. Some plain enum may be substituted throughout the code, such as e.g. `ElementType` or `DistrTypeT`.2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/693Add option to compute percentiles2022-03-08T16:54:12+01:00krausAdd option to compute percentilesThe rms and max bunch size and the normalized emittance of the whole bunch give only an incomplete picture of the actual situation. By computing the 95 (2 sigmas for normal distribution), the 99.7 (3 sigmas) and the 99.99 (4 sigmas) perc...The rms and max bunch size and the normalized emittance of the whole bunch give only an incomplete picture of the actual situation. By computing the 95 (2 sigmas for normal distribution), the 99.7 (3 sigmas) and the 99.99 (4 sigmas) percentiles one can gain more details about the bunch.2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/692New class storing particle properties2022-01-17T08:49:01+01:00ext-calvo_ppedro.calvo@ciemat.esNew class storing particle propertiesFollowing discussion from https://gitlab.psi.ch/OPAL/src/-/merge_requests/542#note_34815, `ParticleType` must be placed into a new file, avoiding having a static function and static map in global scopeFollowing discussion from https://gitlab.psi.ch/OPAL/src/-/merge_requests/542#note_34815, `ParticleType` must be placed into a new file, avoiding having a static function and static map in global scope2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/691Fix units in DumpEMFields header2022-01-17T09:03:08+01:00ext-calvo_ppedro.calvo@ciemat.esFix units in DumpEMFields headerThe header of the output files `DumpEMFields` shows units in `mm` when in fact `m` is used (since 62632e45daedb236457be5909bf7144849404c8a).
The units of the input variables must be specified in the Manual (see OPAL/documentation/manual...The header of the output files `DumpEMFields` shows units in `mm` when in fact `m` is used (since 62632e45daedb236457be5909bf7144849404c8a).
The units of the input variables must be specified in the Manual (see OPAL/documentation/manual#68).2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/690Adding unit conversions to Physics.h2022-03-17T08:53:13+01:00carl_jAdding unit conversions to Physics.hI've updated the Physics.h to include a series of common unit conversions used throughout the code.
So far I've included:
- m <--> mm
- s <--> ns
- T <--> kG
- V <--> kV
- GeV/c^2 <--> kg
I've then used these conversions to replace ...I've updated the Physics.h to include a series of common unit conversions used throughout the code.
So far I've included:
- m <--> mm
- s <--> ns
- T <--> kG
- V <--> kV
- GeV/c^2 <--> kg
I've then used these conversions to replace the hard coded conversions in the following files:
- ParallelCyclotronTracker.cpp
- RK4.h
- OpalMultipoleT.cpp
I've linked [this issue](https://gitlab.psi.ch/OPAL/src/-/issues/357).
There's a bit more discussion on this in the comments there.2022.1carl_jext-rogers_ccarl_jhttps://gitlab.psi.ch/OPAL/src/-/issues/689Fix description of minimum values in monitor statistics2021-10-25T11:42:40+02:00krausFix description of minimum values in monitor statisticsThe description for the values min_x, min_y and min_s claim that the max beamsize in the respective component is stored. Instead it should read min beamsize.The description for the values min_x, min_y and min_s claim that the max beamsize in the respective component is stored. Instead it should read min beamsize.2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/687No values assigned to dispersion2021-11-03T13:20:02+01:00krausNo values assigned to dispersionAll values for the dispersion in statistics file are zero everywhere. The reason is that no values are assigned.All values for the dispersion in statistics file are zero everywhere. The reason is that no values are assigned.2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/685Output file names for LossDataSink can't have prefixed dots if no extension i...2022-03-17T08:55:14+01:00krausOutput file names for LossDataSink can't have prefixed dots if no extension is providedInstead of correct paths an empty string is returned in `ElementBase::getOutputFN()`if the paths start with a prefixed dot such as e.g. `../` and the file name doesn't include an extension. The user shouldn't have to use a file name with...Instead of correct paths an empty string is returned in `ElementBase::getOutputFN()`if the paths start with a prefixed dot such as e.g. `../` and the file name doesn't include an extension. The user shouldn't have to use a file name with extension, the extension is provided by Opal anyway to support both ascii and HDF5 output.2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/684Beam stripping physics in OPAL-t2022-07-08T10:15:01+02:00ext-calvo_ppedro.calvo@ciemat.esBeam stripping physics in OPAL-tBeam stripping interactions are currently restricted to OPAL-cycl.
`VACUUM` element must be adapted to extend the beam stripping physics algorithm to beam lines in OPAL-t.Beam stripping interactions are currently restricted to OPAL-cycl.
`VACUUM` element must be adapted to extend the beam stripping physics algorithm to beam lines in OPAL-t.2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/683Variables of incident particles in OPAL-t elements2021-10-04T07:56:36+02:00ext-calvo_ppedro.calvo@ciemat.esVariables of incident particles in OPAL-t elementsPosition and time variables of incident particles in OPAL-t elements must be adjusted to correspond to the physical boundary of the element.
There are different ways of saving the particles according to each element: `MONITOR` implement...Position and time variables of incident particles in OPAL-t elements must be adjusted to correspond to the physical boundary of the element.
There are different ways of saving the particles according to each element: `MONITOR` implementation is correct, `FLEXIBLECOLLIMATOR` records one step after the element input, `DEGRADER` currently do not save incident particles.
All elements should have the same structure to store the incident particles in the output file.2022.1ext-calvo_ppedro.calvo@ciemat.esext-calvo_ppedro.calvo@ciemat.eshttps://gitlab.psi.ch/OPAL/src/-/issues/682Somethings wrong with the algorithm for spatial monitors2021-09-20T09:25:15+02:00krausSomethings wrong with the algorithm for spatial monitorslongitudinal phase space
![chopped](/uploads/b6883e5e1ef686cc053393a5cd3dc1d7/chopped.png)longitudinal phase space
![chopped](/uploads/b6883e5e1ef686cc053393a5cd3dc1d7/chopped.png)2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/681Use ENABLEHDF5 in OPAL-T2022-02-13T11:50:30+01:00krausUse ENABLEHDF5 in OPAL-TThere is an option ENABLEHDF5 which should allow to disable all HDF5 output. This option doesn’t seem to be supported in OPAL-T.There is an option ENABLEHDF5 which should allow to disable all HDF5 output. This option doesn’t seem to be supported in OPAL-T.2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/680Remove interactive mode, replace it with additional help option.2022-02-04T16:05:23+01:00krausRemove interactive mode, replace it with additional help option.The interactive mode is presumably not used by anyone. I propose therefore to remove it and add instead an option to print the help for commands on the command line.
Additionally I noticed that Opal crashes while printing the help messa...The interactive mode is presumably not used by anyone. I propose therefore to remove it and add instead an option to print the help for commands on the command line.
Additionally I noticed that Opal crashes while printing the help messages. The reason is that the type names `predefined string`, `upper case string` and `upper case string array` are longer than 16 characters. However the user doesn't have to know what these types represent, they are simply strings and string arrays respectively.2022.1krauskraushttps://gitlab.psi.ch/OPAL/src/-/issues/679OPAL header is not printed in interactive mode2021-08-27T14:01:20+02:00gsellOPAL header is not printed in interactive mode### Summary
OPAL header is not printed in interactive mode
### Steps to reproduce
Run opal without argumante
### What is the current *bug* behavior?
No header printed
### What is the expected *correct* behavior?
Print header### Summary
OPAL header is not printed in interactive mode
### Steps to reproduce
Run opal without argumante
### What is the current *bug* behavior?
No header printed
### What is the expected *correct* behavior?
Print headerOPAL 2021.1gsellgsellhttps://gitlab.psi.ch/OPAL/src/-/issues/678Clang does not support option -fno-aggressive-loop-optimizations2021-08-26T15:08:52+02:00gsellClang does not support option -fno-aggressive-loop-optimizationsClang does not support the option `-fno-aggressive-loop-optimizations`.Clang does not support the option `-fno-aggressive-loop-optimizations`.OPAL 2021.1gsellgsell