Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
S src
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 62
    • Issues 62
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OPAL
  • src
  • Issues
  • #79

Closed
Open
Created Mar 28, 2017 by snuverink_j@snuverink_jDeveloper

ArbitraryDomain::globalToLocalQuaternion_m also defined in its parent class 'IrregularDomain

From issue #62. [src/Solvers/ArbitraryDomain.h:84] -> [src/Solvers/IrregularDomain.h:123]: (warning) The class 'ArbitraryDomain' defines member variable with name 'globalToLocalQuaternion_m' also defined in its parent class 'IrregularDomain'.

Shadowing members is very error-prone and was probably not intended.

A quick look at the code seems to show that the derived ArbitraryDomain uses its globalToLocalQuaternion_m as a read-only copy of its parent member. So ArbitraryDomain::globalToLocalQuaternion_m can be safely substituted for a local variable since there is a public getter method (and even the actual parent member is directly accessible (protected)).

Assignee
Assign to
OPAL 1.5.3
Milestone
OPAL 1.5.3
Assign milestone
Time tracking