Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

Introduce a DAP service for simple statistical analysis on images

appel_c requested to merge feature/image_analysis_service into main

Description

This MR introduces a second DAP service for simple statistics on image analysis. Min, max, mean, median, std, and center of mass are computed, and returned as an object. The x/y output can be chosen. For min,max, etc. this will be an increasing index for the processed images for 'x' and the values for 'y'. For center of mass, this will be x/y value for each image.

Related Issues

closes #383 (closed)

Additional Comments

We should discuss the interface to add regions of interest. There are multiple ways, but it would be beneficial to pick a way that is easy to handle for the GUI and CLI. I would postpone this decision though! A continuous mode is not yet implemented. This would require some additional thoughts!

Some additional thoughts:

  • DAPPlugin class is needed if a new service is written. This could be simplified or automated similar as for our widgets. -> bec_lib.dap_plugin_objects
  • Handling arguments or more precisely typehints was tricky. I am not 100% certain whether there is a bug in signature_to_dictionary or if simply needs further review and simplification. -> bec_lib.signature_serializer.signature_to_dict. Can be tested with this (!782 (diffs))
  • Handling of non-typical output might also be interested. Do we always need x and y? In this case, the monitored data might not include all points of the scan. I have to think more about this.

To Do

  • add tests -> done
  • add docs -> issue created #387

Definition of Done

  • Documentation is up-to-date.
Edited by appel_c

Merge request reports