Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

Various smaller improvements

wakonig_k requested to merge ci/nightly_e2e_fix into main

Description

There is still a bug in the SimPositioner which I struggle to solve atm, however, this MR solves a few other issues I encountered whilst trying to solve it.

Type of Change

  • Fix CI file for nightly e2e tests (3e55d44e)
  • Improved logging for failed device inits (27d29128)
  • The Device config should only be applied after the device is added to the Devicemanager. This ensures that if an error is raised, the device can be disabled (9f84eb85)
  • Fixed the shutdown of the threadpool in the redis connector (8a2e8f2a)
  • If a status object resolves before the status itself is added to the rpc handler, it may not resolve properly. Directly checking for finished status objects upon insert should solve it (84d22c71)
  • Removed legacy blocking calls from the scan storage to avoid the client getting stuck if the queue update is not the first message to receive (d45f3f21)
  • Fixed the logger file path for e2e tests (42751932)
  • Added the option to specify the minimum wait time for the monitor scan (f028ad90). This can be used to reduce the load during the test (825cf348)
  • To better identify the status objects and their current state, I added the done flag to their string representation (8bbe6e4f and e0ac994d)
  • If the request handler was already resolved before one tries to patch the number of objects, the patch itself is unnecessary and should not lead to a ValueError (15da77e0)

Additional Comments

[Add any additional comments or information that may be helpful for reviewers.]

Definition of Done

  • Documentation is up-to-date.
Edited by wakonig_k

Merge request reports