Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

Improve `CustomDetectorMixin` from *psi_detector_base* `on_trigger/complete` methods

appel_c requested to merge feat/psi_detector_base_add_status_return_complete_trigger into main

Description

This MR improves the functionality of psi_detector_base.custom_prepare_class' methods on_trigger/complete to return a ophyd.DeviceStatus` object (optionally).

Related Issues

closes #74 (closed)

Type of Change

  • adapted trigger/complete method
  • extend CustomDetectorMixin with new function (wait_with_status, to wrap around the wait_for_signal method) and return a DeviceStatus which can be used by BEC to wait for signals to resolve.

Potential side effects

Not aware of any, should refactor beamline plugin class with on_complete/trigger methods if necessary.

Comments

This should be backwards compatible. I tested with the cSAXS_bec repo. FYI, we should consider setting up a documentation for a detector integration, i.e. step-by-step guide. Dedicated functionality of different functions of CustomDetectorMixin could be explained there.

Definition of Done

  • Documentation is up-to-date.

Merge request reports