Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

Revert 2D/3D support

Merged vinciguerra_a requested to merge revert-2d into master
All threads resolved!

Revert "Merge branch '87-add-mdrangepolicy-generator-for-arbitrary-dimensions-2' into 'master'"

This reverts commit a752facc, reversing changes made to 07468628.

The following commits are preserved:

  • replace TestFieldNorm with unit test
  • more rigorous normInf test

A comment to this MR: We do this revert since NVCC (11.0) has problems with SFINAE. We therefore disable the support of 2D fields until NVCC is able to handle this or we find a better solution. The use of if constexpr fails too (although it compiles).

  • comment by frey_m (copied for visibility)

Reopens #87 (closed)

Edited by vinciguerra_a

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Maintainer

    A comment to this MR: We do this revert since NVCC (11.0) has problems with SFINAE. We therefore disable the support of 2D fields until NVCC is able to handle this or we find a better solution. The use of if constexpr fails too (although it compiles).

    Edited by frey_m
  • frey_m added NVCC label

    added NVCC label

  • vinciguerra_a changed the description

    changed the description

  • vinciguerra_a added 1 commit

    added 1 commit

    • 72740a75 - Put back 3D range policy generator

    Compare with previous version

  • vinciguerra_a resolved all threads

    resolved all threads

  • vinciguerra_a changed the description

    changed the description

  • vinciguerra_a added 1 commit

    added 1 commit

    • 5737baac - Put back 3D range policy generator

    Compare with previous version

  • frey_m resolved all threads

    resolved all threads

  • frey_m approved this merge request

    approved this merge request

  • merged

  • vinciguerra_a mentioned in commit c1975a2e

    mentioned in commit c1975a2e

  • Please register or sign in to reply
    Loading