because of new collimator implementation we habe tiny changes in the number of surviving particles
- RegressionTests/BeamLine-1/reference/BeamLine-1.lbal 38 additions, 38 deletionsRegressionTests/BeamLine-1/reference/BeamLine-1.lbal
- RegressionTests/BeamLine-1/reference/BeamLine-1.lbal.md5 1 addition, 1 deletionRegressionTests/BeamLine-1/reference/BeamLine-1.lbal.md5
- RegressionTests/BeamLine-1/reference/BeamLine-1.out 99 additions, 100 deletionsRegressionTests/BeamLine-1/reference/BeamLine-1.out
- RegressionTests/BeamLine-1/reference/BeamLine-1.out.md5 1 addition, 1 deletionRegressionTests/BeamLine-1/reference/BeamLine-1.out.md5
- RegressionTests/BeamLine-1/reference/BeamLine-1.stat 68 additions, 68 deletionsRegressionTests/BeamLine-1/reference/BeamLine-1.stat
- RegressionTests/BeamLine-1/reference/BeamLine-1.stat.md5 1 addition, 1 deletionRegressionTests/BeamLine-1/reference/BeamLine-1.stat.md5
- RegressionTests/BeamLine-2/reference/BeamLine-2.lbal 39 additions, 39 deletionsRegressionTests/BeamLine-2/reference/BeamLine-2.lbal
- RegressionTests/BeamLine-2/reference/BeamLine-2.lbal.md5 1 addition, 1 deletionRegressionTests/BeamLine-2/reference/BeamLine-2.lbal.md5
- RegressionTests/BeamLine-2/reference/BeamLine-2.out 892 additions, 1132 deletionsRegressionTests/BeamLine-2/reference/BeamLine-2.out
- RegressionTests/BeamLine-2/reference/BeamLine-2.out.md5 1 addition, 1 deletionRegressionTests/BeamLine-2/reference/BeamLine-2.out.md5
- RegressionTests/BeamLine-2/reference/BeamLine-2.stat 68 additions, 68 deletionsRegressionTests/BeamLine-2/reference/BeamLine-2.stat
- RegressionTests/BeamLine-2/reference/BeamLine-2.stat.md5 1 addition, 1 deletionRegressionTests/BeamLine-2/reference/BeamLine-2.stat.md5
- RegressionTests/PROSCAN-1/reference/PROSCAN-1.lbal 471 additions, 471 deletionsRegressionTests/PROSCAN-1/reference/PROSCAN-1.lbal
- RegressionTests/PROSCAN-1/reference/PROSCAN-1.lbal.md5 1 addition, 1 deletionRegressionTests/PROSCAN-1/reference/PROSCAN-1.lbal.md5
- RegressionTests/PROSCAN-1/reference/PROSCAN-1.out 624 additions, 627 deletionsRegressionTests/PROSCAN-1/reference/PROSCAN-1.out
- RegressionTests/PROSCAN-1/reference/PROSCAN-1.out.md5 1 addition, 1 deletionRegressionTests/PROSCAN-1/reference/PROSCAN-1.out.md5
- RegressionTests/PROSCAN-1/reference/PROSCAN-1.stat 472 additions, 472 deletionsRegressionTests/PROSCAN-1/reference/PROSCAN-1.stat
- RegressionTests/PROSCAN-1/reference/PROSCAN-1.stat.md5 1 addition, 1 deletionRegressionTests/PROSCAN-1/reference/PROSCAN-1.stat.md5
- RegressionTests/PROSCAN-2/reference/PROSCAN-2.lbal 528 additions, 473 deletionsRegressionTests/PROSCAN-2/reference/PROSCAN-2.lbal
- RegressionTests/PROSCAN-2/reference/PROSCAN-2.lbal.md5 1 addition, 1 deletionRegressionTests/PROSCAN-2/reference/PROSCAN-2.lbal.md5
-
In the old implementation it was tested whether the particle is inside at
R_i + \Delta t \cdot \beta_i \cdot c
whereas in the new implementation we test atR_i
. This could explain the difference in the results.Edited by kraus -
I have to correct the above statement.
R_i + \Delta t \cdot \beta_i \cdot c
is used only to determine whether a particle is inside the element:const double z = R(2) + P(2) * recpgamma; if ((z > 0.0) && (z <= getElementLength())) {
I don't know what the motivation was to implement it this way. It's not comprehensible to me.
-
I just explained where the differences in the results stem from and that it was justified to update the reference.
We could discuss whether it makes sense to use
z = R(2) + P(2) + recpgamma
to testz > 0 && z <= getElementLength()
or, as we do now,z = R(2)
. I don't see any reason to use the former.