don't disable glibcxx_assertions when the build type is Release but if the...

don't disable glibcxx_assertions when the build type is Release but if the variable BUILD_FOR_PRODUCTION is ON

CMakeLists.txt

 cmake_minimum_required (VERSION 3.1)
 project (OPAL VERSION 2.5.0)
 set (PROJECT_BUGREPORT opal@lists.psi.ch)
+set (BUILD_FOR_PRODUCTION OFF)
 
 string (REGEX REPLACE "\\.([0-9])\\." ".0\\1." PACKAGE_VERSION ${PROJECT_VERSION})
 string (REGEX REPLACE "\\.([0-9])$" ".0\\1" PACKAGE_VERSION ${PACKAGE_VERSION})
@@ -101,8 +102,7 @@ elseif (${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
 
     # Enables extra error checking in the form of precondition assertion, such
     # as bounds checking and null pointer checks when dereferencing smart pointers
-    string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
-    if (uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELWITHDEBINFO)$")
+    if (NOT BUILD_FOR_PRODUCTION)
         add_compile_options(-Wp,-D_GLIBCXX_ASSERTIONS)
     endif()
 else ()

[snuverink_j]

Instead of using set perhaps this can become an option instead? Then it can be interactively selected with ccmake or on the command line with -DBUILD_FOR_PRODUCTON=ON.

[gsell]

I agree an option might be the better solution. Proposal:

• option is off by default for dev. versions
• option is on by default for released versions

[kraus]

Ok, I can change it to an option but I would rather require that both the option is on and the compile type be release in order to disable this flag. [Edit:] I implemented it the way @gsell proposed. [/Edit]