Revert "don't disable glibcxx_assertions when the build type is Release but if...

Revert "don't disable glibcxx_assertions when the build type is Release but if the variable BUILD_FOR_PRODUCTION is ON"

This reverts commit 197cf862.

CMakeLists.txt

 cmake_minimum_required (VERSION 3.1)
 project (OPAL VERSION 2.5.0)
 set (PROJECT_BUGREPORT opal@lists.psi.ch)
-set (BUILD_FOR_PRODUCTION OFF)
 
 string (REGEX REPLACE "\\.([0-9])\\." ".0\\1." PACKAGE_VERSION ${PROJECT_VERSION})
 string (REGEX REPLACE "\\.([0-9])$" ".0\\1" PACKAGE_VERSION ${PACKAGE_VERSION})
@@ -102,7 +101,8 @@ elseif (${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
 
     # Enables extra error checking in the form of precondition assertion, such
     # as bounds checking and null pointer checks when dereferencing smart pointers
-    if (NOT BUILD_FOR_PRODUCTION)
+    string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
+    if (uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELWITHDEBINFO)$")
         add_compile_options(-Wp,-D_GLIBCXX_ASSERTIONS)
     endif()
 else ()