Objectives for Sampler

The user should be able to define quantities of interest (a la optimizer) which are written to the json file. This avoids lengthy post processing of the stat files of all runs.

marked this issue as related to #239 (closed)

mentioned in issue #239 (closed)

This is a cool idea and very helpful.

@frey_m indeed. I'm more or less there. Just have to add objectives to the json file and test it. Then I'll push it to the repo.

I think sooner or later we want to have the FULL stat file of all runs in one file. Not sure if the json file format is suitable. Any other idea? H5?

I don't think that storing all stat files will replace the objectives,it'll supplement it.

mentioned in commit 0fe87fd1

The objectives are now added. I'll register a new 'feature request' issue for the storage of the stat files.

closed

marked this issue as related to #250

@kraus: could you also update the manual? (https://gitlab.psi.ch/OPAL/Manual-2.1/wikis/sampler)

added Add/modify Doc label

Yes, sure!

Could it be that with this change the usual individual output directories are deleted? This was seen by Melina (@luethi_m).

Yes indeed. I'll post the fix in a few minutes.

Ok, it's fixed.

added Sampler label

mentioned in issue #265 (closed)

mentioned in commit 49ccf829

@kraus According to the code storeobjstr variable and statVariablesToStore_m aren't needed. I'll remove if you agree.

This isn't fully implemented yet. We'll have to wait until H5hut can handle concurrently writing processes (probably implemented until St. Nimmerleinstag).

Is that something @gsell knows?

Sure see #250.

@kraus Ok, then I do not remove.

@frey_m could you add a code comment instead? otherwise this will come up again.

@snuverink_j 0b38169d

Actually there is a comment here that points to the open issue... "Doppelt gemoppelt hält besser" (double bolted holds better [or so...]).