Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
S src
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 62
    • Issues 62
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OPAL
  • src
  • Issues
  • #409

Closed
Open
Created Jan 06, 2020 by snuverink_j@snuverink_jDeveloper

`DISTRIBUTION, CUTOFFPZ = 0` does not imply cutoff infinity and produces infinite loop

Summary

The documentation of DISTRIBUTION, CUTOFFPZ = 0 mentions an infinity cutoff, but this is currently not true.

Steps to reproduce

set DISTRIBUTION, CUTOFFPZ = 0

What is the current bug behavior?

Infinite loop

What is the expected correct behavior?

According to the manual CUTOFFPZ:

Defines cutoff in p_{z} dimension in units of \sigma_{pz}. If CUTOFFPZ = 0 then actual cutoff is p_{z} is set to infinity.

Possible fixes

The following line in Distribution.cpp should be changed for cutoffP_m[2] in a similar way as x and y:

            allow = (xAndYOk && pxAndPyOk && std::abs(z) < cutoffR_m[2] && std::abs(pz) < cutoffP_m[2]);

Varia

For consistency I propose also to make CUTOFFLONG=0 an infinite cutoff.

Assignee
Assign to
OPAL 2.4.0
Milestone
OPAL 2.4.0 (Past due)
Assign milestone
Time tracking