New MITHRA module for Undulator

While fixing the Undulator regression tests (#658 (closed)) we found some bugs in MITHRA.

I have opened issues and MRs in the Mithra repo to fix this, and once this is fixed we should make a new MITHRA module for Merlin.

• Resolve issues and MRs in the Mithra repository
• Test Mithra's master branch with OPAL and implement necessary changes in Undulator.cpp
• Ask Arya (Mithra developer) to make new release MITHRA-2.1
• Achim compiles module on Merlin

changed milestone to %2022.1

added OPAL-T To Do Work in progress labels

changed weight to 1

mentioned in issue #658 (closed)

changed milestone to %2022.2

@albajacas_a: Undulator regression tests fail recursively (see results_2023-09-10, results_2023-09-23, results_2023-10-04). I don't know if the bug is related to #658 (closed), but I think we should work out the underlying issues

My interpretation is that the initial conditions are slightly different.

Would you agree ?

I don't understand, this issue got fixed in #658 (closed) by making sigma_pz non-zero. I looked at recent commits but can't see any obvious thing. The only suspicious one is #765 (closed). Do you have an idea of how that commit might break this test? Do you know if some other commit might affect sigma_pz?

And could you please remind me how one can check the logs of the regressions tests? I can't find it, thanks

None of the last commits affect the distribution class or the undulator element. #765 (closed) has only introduced an input parameter for momentum tolerance with the same default value than before.

The first regression test failure after add sigma_pz non-zero was 2023-08-17. You can find all the regression tests results here.

Note that the rms_x test also fails, unlike the previous bug #658 (closed). I guess it is an initialization problem, maybe related to MITHRA problems.

removed milestone %2022.2