Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S src
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 59
    • Issues 59
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OPAL
  • src
  • Merge requests
  • !108

Merged
Created Jun 14, 2019 by snuverink_j@snuverink_jDeveloper2 of 2 tasks completed2/2 tasks

Resolve "PluginElements: particles not recorded when element crosses (or close to) origin"

  • Overview 44
  • Commits 11
  • Changes 15

What does this MR do?

  • fix #313 (closed) (plugin elements in multiple quadrants), by calculating the radius closest to the origin per plugin element (rmin_m).
  • refactor and force more structure to PluginElement::Check(). This is work towards unifying the geometry check of all plugin elements.
  • reduce duplication and several other improvements (see Discussion).

Does this MR meet the acceptance criteria?

  • Coding style guidelines
  • Change to Release Notes

Bug

Edited Jul 09, 2019 by snuverink_j
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 313-pluginelements-particles-not-recorded-when-element-crosses-or-close-to-origin