Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S src
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 59
    • Issues 59
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OPAL
  • src
  • Merge requests
  • !159

Merged
Created Jul 27, 2019 by kraus@krausDeveloper

improve ElementPositionWriter and SDDSColumn

  • Overview 5
  • Commits 2
  • Changes 7

The current implementation of the computation of the data for the ElementPositionWriter and fix a problem with the existing implementation: currently the rows are written as if all elements in a "sector" start and and simultaneously, see the following example

      0.11569476         0     0     0     0     0     0     0     0     1     1 "WEDGE1, MDEGD1"
      0.11931035         0     0     0     0     0     0     0     0     1     1 "WEDGE1, MDEGD1"
      0.11931035         0     0     0     0     0     0     0     0     1     1 ""
      0.11931035         0     0     0     0     0     0     0     0     1     1 ""
      0.11931035         0     0     0     0     0     0     0     0     1     1 "MDEGD1, DEGD1"
      0.12111484         0     0     0     0     0     0     0     0     1     1 "MDEGD1, DEGD1"

The correct output should be

0.115694755         0       0       0       0       0       0       0       0       1       1       "MDEGD1, WEDGE1"
0.1193103499        0       0       0       0       0       0       0       0       1       1       "MDEGD1, WEDGE1"
0.1193103499        0       0       0       0       0       0       0       0       1       0       "MDEGD1"
0.1193103499        0       0       0       0       0       0       0       0       1       0       "MDEGD1"
0.1193103499        0       0       0       0       0       0       0       0       1       1       "MDEGD1, DEGD1"
0.121114842         0       0       0       0       0       0       0       0       1       1       "MDEGD1, DEGD1"

The columns in these two extracts are position, different multipole magnets (dipole to decapole and everything above), solenoids, rfcavities, monitors and others (such as degraders). Ignore the different formatting but notice the second last column (others) in the two rows with "" (first extract from old implementation) which should be 0 instead of 1.

Additionally one can chose a format and precision for each column.

Edited Jul 27, 2019 by kraus
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: SDDSWriterLossDataSink2