Resolve "CMAKE add on NERSC" (!165) · Merge requests · OPAL / src · GitLab

Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Snippets Groups Projects

Please migrate repositories to https://gitea.psi.ch - if you need help, contact gitea@psi.ch

Merged gsell requested to merge 350-cmake-add-on-nersc into master 5 years ago

1 unresolved thread

Activity

gsell changed milestone to %OPAL 2.0.0 5 years ago

changed milestone to %OPAL 2.0.0
gsell added Bug + 1 deleted label 5 years ago

added Bug + 1 deleted label
gsell added 1 commit 5 years ago
added 1 commit

b13fc10a - check Boost version with 'find_package()'

Compare with previous version
gsell @gsell · 5 years ago

Author Owner

The issue has nothing to do with NERSC. The problem is, that the FindBoost.cmake module of cmake returns Boost_VERSION in older version (<= 3.10?) as a number (like 106800) and in newer version (>= 3.15?) as a normal version string (like 1.68.0).

The version check in OPAL's CMakeList.txt can and should be done in find_package(Boost ...).
gsell unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress
gsell changed the description 5 years ago

changed the description
gsell assigned to @gsell 5 years ago

assigned to @gsell
kraus approved this merge request 5 years ago

approved this merge request
frey_m approved this merge request 5 years ago

approved this merge request
snuverink_j @snuverink_j started a thread on the diff 5 years ago

CMakeLists.txt

 endif ()
 set (Boost_USE_MULTITHREADED OFF)
 set (Boost_USE_STATIC_RUNTIME OFF)
 find_package (Boost
 find_package (Boost 1.60.0

gsell merged 5 years ago

merged

gsell mentioned in commit 5 years ago

mentioned in commit 391a294d

gsell mentioned in merge request !166 (merged) 5 years ago

mentioned in merge request !166 (merged)

gsell mentioned in issue #350 (closed) 5 years ago

mentioned in issue #350 (closed)

Please register or sign in to reply