Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in
S
src
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 75
    • Issues 75
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • OPAL
  • src
  • Merge Requests
  • !361

Merged
Opened May 06, 2020 by albajacas_a@albajacas_a22 of 22 tasks completed22/22 tasks
  • Report abuse
Report abuse

Resolve "OPAL-FEL (MITHRA integration)"

  • Overview 173
  • Commits 291
  • Changes 25

For #535 (closed)

  • Move documenation from README to manual (will be done when MR gets merged)
  • Move example to Wiki (will be done when MR gets merged)
  • Remove unnecessary file and line info at the start of MITHRA
  • Review use of *new
  • Reorganise folders of MITHRA library lib , bin, ...
  • Correct use of OPAL functions e.g. euclidean_norm()
  • Remove unnecessary variables e.g. cfname
  • OPAL constants instead of a "magic number"
  • Remove unnecessary vector.clear()
  • Move code from UndulatorRep.[cpp|h] to Undulator.[h|cpp]
  • Remove ParticleMatterInteraction, , wakeField, BoundaryGemoetry
  • File header with correct coding style
  • Alphabetic order in CMakeLists.txt and other places in the code
  • Conditional include MITHRA header files with #ifdef OPAL_FEL, ..., #endif
  • Surround OPAL FEL code in other files with #ifdef OPAL_FEL, ..., #endif
  • Check which header files are really required
  • Use only C++ header files
  • Check and correct indentation
  • Use plural for variable names of containers (usually something we loop over)
  • Bunch needs to be recovered by OPAL after undulator instead of using globalEOL_m = true
  • Separate computeUndulator() in a file that is only compiled if OPAL_FEL enabled. EDIT 14-5: I think the idea is to put the computeUndulator() code in the Undulator class - Jochem
  • Write unit tests for the new classes
Edited Aug 27, 2020 by albajacas_a
Assignee
Assign to
OPAL 2.6
Milestone
OPAL 2.6
Assign milestone
Time tracking
2
Labels
Enhancement Feature request
Assign labels
  • View project labels
Reference: OPAL/src!361

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.