Resolve "segmentation fault in unit-test Field.PeriodicBC" (!402) · Merge requests · OPAL / src · GitLab

Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Snippets Groups Projects

Please migrate repositories to https://gitea.psi.ch - if you need help, contact gitea@psi.ch

Merged snuverink_j requested to merge 570-segmentation-fault-in-unit-test-field-periodicbc into master 4 years ago

All threads resolved!

This MR:

Resets output stream in PeriodicBC. This fixes an occassional segfault when running multiple tests after each other (closes #570 (closed)) (a299a45f)
Fixes memory errors in unit tests as reported by valgrind: initialise array, check for container end, array deletion (eeda59a1)
Adds license header and cleans up whitespace for the affected IPPL files (ca98271d)

Edited 4 years ago by snuverink_j

Activity

snuverink_j changed milestone to %OPAL 2.4.0 4 years ago

changed milestone to %OPAL 2.4.0
snuverink_j added Bug label 4 years ago

added Bug label
snuverink_j added 3 commits 4 years ago
added 3 commits

a299a45f - reset output stream, fixes segfault in PeriodicBC when running multiple tests...

eeda59a1 - fix memory errors in unit tests as reported by valgrind: initialise array,...

ca98271d - license header and whitespace cleanup

Compare with previous version
snuverink_j unmarked as a Work In Progress 4 years ago

unmarked as a Work In Progress
snuverink_j changed the description 4 years ago

changed the description
snuverink_j assigned to @snuverink_j 4 years ago

assigned to @snuverink_j
frey_m @frey_m started a thread on the diff 4 years ago

Resolved 4 years ago by frey_m
Last reply by snuverink_j 4 years ago

snuverink_j added 1 commit 4 years ago

added 1 commit

853bc92e - throw exception instead of silent pass

Compare with previous version

snuverink_j added 1 commit 4 years ago

added 1 commit

a53f404e - fix function name

Compare with previous version

frey_m resolved all discussions 4 years ago

resolved all discussions

frey_m approved this merge request 4 years ago

approved this merge request

adelmann @adelmann · 4 years ago

Owner

Resolved 4 years ago by snuverink_j

@snuverink_j would approve if you let me
Last reply by snuverink_j 4 years ago

gsell approved this merge request 4 years ago

approved this merge request

snuverink_j resolved all discussions 4 years ago

resolved all discussions

snuverink_j mentioned in commit 4 years ago

mentioned in commit 99361fd6

snuverink_j merged 4 years ago

merged

Please register or sign in to reply