Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

Resolve "compiler errors with AMR / SAAMG enabled"

Merged frey_m requested to merge 587-compiler-errors-with-amr-enabled into OPAL-2.4

Closes #587 (closed)

Edited by frey_m

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • frey_m added 1 commit

    added 1 commit

    • efbda3cc - AmrInterpolater: fix documentation

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    • 7458e91f - BelosBottomSolver: fix cloning

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    • 036efb30 - AmrMultiGrid: fix function call

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    • 2a8f987b - AmrLagrangeInterpolater: unused parameter

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    • e80b5b38 - MueLuPreconditioner: no rebalancing

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    • 1d82419d - AmrMultiGrid: fix function signature

    Compare with previous version

  • frey_m added 1 commit

    added 1 commit

    • 4c58f9cb - MueLuPreconditioner: conversion

    Compare with previous version

  • frey_m resolved all discussions

    resolved all discussions

  • assigned to @frey_m

  • On macOS with Clang 11 I still get the following error:

    /Users/gsell/src/OPAL/src/src/Solvers/AMR_MG/BelosBottomSolver.hpp: In member function 'void BelosBottomSolver<Level>::setOperator(const Teuchos::RCP<Tpetra::CrsMatrix<double, int, long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> > >&, Level*)':
    /Users/gsell/src/OPAL/src/src/Solvers/AMR_MG/BelosBottomSolver.hpp:75:55: error: no matching function for call to 'Tpetra::CrsMatrix<double, int, long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> >::CrsMatrix(Tpetra::CrsMatrix<double, int, long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> >&, Teuchos::DataAccess)'
       75 |     A_mp = Teuchos::rcp(new matrix_t(*A, Teuchos::Copy));
    • Resolved by frey_m

      The problems with the aggressive loop optimisation we have to solve with #pragma statements

      make[2]: *** [src/CMakeFiles/libOPAL.dir/build.make:5224: src/CMakeFiles/libOPAL.dir/Structure/FieldSolver.cpp.o] Error 1
      In member function 'void Ifpack2::Impl::InvertDiagBlocks<BlockDiagView>::operator()(Ifpack2::Impl::InvertDiagBlocks<BlockDiagView>::Size, int&) const [with BlockDiagView = Kokkos::View<double***, Kokkos::Device<Kokkos::Serial, Kokkos::HostSpace>, Kokkos::MemoryTraits<1> >]':
      cc1plus: error: iteration 2147483649 invokes undefined behavior [-Werror=aggressive-loop-optimizations]
      In file included from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Tpetra_Experimental_BlockMultiVector_decl.hpp:46,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Tpetra_Experimental_BlockMultiVector.hpp:1,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Tpetra_Experimental_BlockCrsMatrix_decl.hpp:50,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Relaxation_decl.hpp:52,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Relaxation.hpp:1,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Details_OneLevelFactory_def.hpp:51,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Details_OneLevelFactory.hpp:2,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Details_Factory_def.hpp:46,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Details_Factory.hpp:2,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Factory_decl.hpp:48,
                       from /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Ifpack2_Factory.hpp:1,
                       from /Users/gsell/src/OPAL/src/src/Solvers/AMR_MG/AmrSmoother.h:28,
                       from /Users/gsell/src/OPAL/src/src/Solvers/AMR_MG/AmrSmoother.cpp:21:
      /Users/gsell/OPAL-gcc-mp9-openmpi316/include/Tpetra_Experimental_BlockView.hpp:1247:34: note: within this loop
       1247 |   for(IndexType j = numCols-2; j >= 0; j--) {
  • frey_m unmarked as a Work In Progress

    unmarked as a Work In Progress

  • frey_m changed target branch from master to OPAL-2.4

    changed target branch from master to OPAL-2.4

  • frey_m changed milestone to %OPAL 2.4.0

    changed milestone to %OPAL 2.4.0

  • snuverink_j
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading