Don't use GLIBCXX_ASSERTIONS in production

Closes #627 (closed)

I assumed that this flag GLIBCXX_ASSERTIONS has no effect when the build type is Release. However I did some timing measurements and observed an increase of ~6 percent when using. This is fine for development builds but not for production.

CMakeLists.txt

 cmake_minimum_required (VERSION 3.1)
 project (OPAL VERSION 2.5.0)
 set (PROJECT_BUGREPORT opal@lists.psi.ch)
+set (BUILD_FOR_PRODUCTION OFF)
 
 string (REGEX REPLACE "\\.([0-9])\\." ".0\\1." PACKAGE_VERSION ${PROJECT_VERSION})
 string (REGEX REPLACE "\\.([0-9])$" ".0\\1" PACKAGE_VERSION ${PACKAGE_VERSION})
@@ -101,8 +102,7 @@ elseif (${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
 
     # Enables extra error checking in the form of precondition assertion, such
     # as bounds checking and null pointer checks when dereferencing smart pointers
-    string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
-    if (uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELWITHDEBINFO)$")
+    if (NOT BUILD_FOR_PRODUCTION)
         add_compile_options(-Wp,-D_GLIBCXX_ASSERTIONS)
     endif()
 else ()