Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

Resolve 'Delete particles that move in the opposite direction than the bunch.'

All threads resolved!

Closes #632 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Author Developer
      Resolved by ext-calvo_p

      Initially I wanted to delete only those particles that move in the opposite direction. Then I noticed that Opal-Cycl uses 'Option::REMOTEPARTDEL' to delete those particles that are further away than x times the rms. (NB: the manual says that if the value is equal to -1 then this has no effect. However the method PartBunchBase::boundp_destroyCycl also deletes particles if the value is -1. Furthermore the default value is 0 and not -1 as stated in the manual. Finally boundp_destroyCycl converts the floating point value to an integer which doesn't seem necessary, e.g 2.5 times

      σ\sigma
      should work as well.).

      I use this option a bit different since I only want to delete particles that are far away from the mean position in longitudinal direction. And OpalT ignores all negative values of REMOTEPARTDEL.

      Only loosely related to this issue: I also remove the method setMinimumNumberOfParticlesPerCore and getMinimumNumberOfParticlesPerCore since the minimum number of particles was always 0 and this never worked properly due to scattering of the charge and gathering of the induced field.

      Edited by kraus
  • kraus added 1 commit

    added 1 commit

    • 44c83fd6 - delete all particles that farther away than x times sigma; remove unused Inform instance

    Compare with previous version

  • snuverink_j approved this merge request

    approved this merge request

  • snuverink_j resolved all threads

    resolved all threads

  • ext-calvo_p approved this merge request

    approved this merge request

  • ext-calvo_p changed milestone to %OPAL 2021.1

    changed milestone to %OPAL 2021.1

  • kraus mentioned in commit 351f323f

    mentioned in commit 351f323f

  • merged

  • ext-calvo_p resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading