Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

Disable periodic BC's until its is supported by IPPL

Closed Disable periodic BC's until its is supported by IPPL
119-periodic-bc-s into master
2 unresolved threads
Closed kraus requested to merge 119-periodic-bc-s into master
2 unresolved threads

Throw an exception if the user tries to simulate with a periodic field solver. For #119

Edited by snuverink_j

Merge request reports

Closed by krauskraus 3 years ago (Jun 10, 2021 8:58am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/Structure/FieldSolver.cpp
462 462 bcz = Attributes::getString(itsAttr[BCFFTZ]);
463 463 }
464 464
465 if (bcz == "PERIODIC" || bcx == "PERIODIC" || bcy == "PERIODIC") {
466 throw OpalException("FieldSolver::init", "Periodic boundaries aren't supported at the moment");
467 }
  • snuverink_j
    snuverink_j @snuverink_j started a thread on the diff
    • src/Structure/FieldSolver.cpp
    462 462 bcz = Attributes::getString(itsAttr[BCFFTZ]);
    463 463 }
    464 464
    465 if (bcz == "PERIODIC" || bcx == "PERIODIC" || bcy == "PERIODIC") {
    466 throw OpalException("FieldSolver::init", "Periodic boundaries aren't supported at the moment");
  • snuverink_j
    snuverink_j @snuverink_j ·
    Developer

    I am not very familiar with the boundary conditions part in OPAL, so I added @adelmann and @winklehner_d as approvers.

  • kraus
    kraus @kraus ·
    Author Developer

    I must have misunderstood something in yesterday's discussion. It seems that the fix is quite simple.

    I close this MR and fix it properly.

  • kraus closed

    closed

    • Please register or sign in to reply