Resolve "Check momentum between `FROMFILE` distribution and BEAM"
Related to #701 (closed)
Merge request reports
Activity
added Bug label
added 1 commit
- f313cfed - FROMFILE distribution cross-checks momentum with BEAM command
requested review from @adelmann, @ext-calvo_p, and @kraus
- Resolved by ext-calvo_p
Note that when we merge this, all the regression tests that use
FROMFILE
and the defaultP0
will fail, so will also need to be updated.Edited by albajacas_a
mentioned in issue #701 (closed)
- Resolved by ext-calvo_p
changed milestone to %2022.1
- Resolved by albajacas_a
added 1 commit
- 3a747a2b - check BEAM momentum for FROMFILE distribution in OPAL-cycl
assigned to @ext-calvo_p
requested review from @snuverink_j and removed review request for @ext-calvo_p
- Resolved by ext-calvo_p
- Resolved by ext-calvo_p
- Resolved by albajacas_a
I haven't checked all the comments, but I thought the idea was to remove the need for redundant information? While in the chosen solution the user needs to specify the energy two times.
- Resolved by snuverink_j
I don't quickly see a different solution, and you probably gave this a thought, but the fact that there is a different solution for
Opal-T
andOpal-Cycl
indicates bad design.Edited by snuverink_j
- Resolved by snuverink_j