Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

No symbol warnings mac

Merged snuverink_j requested to merge (removed):noSymbolWarningsMac into master

When compiling OPAL on Mac there are the following warnings:

/opt/local/bin/ranlib: file: libOPAL.a(Tps.cpp.o) has no symbols

This is correct and there are 3 different reasons for this and this MR fixes those by:

  • Rename pure template implementations from .cpp to .hpp and remove those in CMakeLists.txt from sources and add to headers
  • add a HAVE_SAAMG_SOLVER check in Solvers/CMakeLists to consider files that are only relevant for SAAMG only when needed
  • delete the empty source file VectorMap.cpp

Merge request reports

Approval is optional

Merged by snuverink_jsnuverink_j 5 years ago (Apr 29, 2019 8:25am UTC)

Merge details

  • Changes merged into master with 6d4ff07f (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading