Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

Draft: Resolve "config_helper: wait_for_service_response makes many calls to LRANGE"

guijar_m requested to merge 165-config_helper-wait_for_service_response-makes-many-calls-to-lrange into main

Description

Instead of polling redis with LRANGE, and re-reading the whole list if it is not empty, just to know if 2 services have replied, the code of this MR uses BRPOP and let redis-py to manage timeout and to do an efficient wait (the smallest possible), because redis answers only if something arrives in the list.

Potential side effects

Elements returned by BRPOP are actually removed from the list. I think it's good (what was removing those before ?) but maybe it is not.

Closes #165

Merge request reports