fix(redis_connector): unregister is not killing communication
Description
Calling of RedisConnector.unregister
caused killing of the receiving communication for that connector. There is a problem with the logic in _filter_topics_cb
(line 544
), where unsubscribe_list
is never filled, thus returning empty list. Then if empty list is passed to self._pubsub_conn.punsubscribe(pubsub_unsubscribe_list)
(line 574
or 580
).
This MR do not solve the non-functionality of .unregister
, just patches the connector to not kill the communication and not call self._pubsub_conn.punsubscribe(pubsub_unsubscribe_list)
with empty list.
The .unregister
method has to be investigated and tested further (see #276 (moved))
Related Issues
[Cite any related issues or feature requests that are addressed or resolved by this merge request. Use the gitlab syntax for linking issues, for example, fixes #123
or closes #123
.]
Type of Change
-
self._pubsub_conn.punsubscribe(pubsub_unsubscribe_list)
is called only if the list is not empty
Potential side effects
Not fully known
Definition of Done
-
Documentation is up-to-date.