Draft: fix(curve_dialog): changed LineEdits to SignalLineEdits
Description
Change LineEdits
of curve_dialog to SignalLineEdits
Related Issues
closes #394
Type of Change
- Changed curve dialog line edits to use signal line edits
Potential side effects
@appel_c Not sure if this is bug with SignalLineEdit or CurveDialog, but the SignalLineEdit is always red even though the signal is correct. In Designer I have same problem. Can you check it?
Screenshots / GIFs (if applicable)
[Include any relevant screenshots or GIFs to showcase the changes made.]
Additional Comments
- Waveform widget works, however
SignalLineEdit
is always red from some reason. You can try just to runwidgets/waveform/waveform_widget.py
- tests will be fixed later when the appearance of signal line edits is fixed
Definition of Done
-
Documentation is up-to-date.
Merge request reports
Activity
assigned to @wyzula_j
requested review from @appel_c
added prioritynice to have scopefrontend typebug labels
added 5 commits
-
1831505e...d8c80293 - 3 commits from branch
main
- 54598cff - fix(curve_dialog): changed LineEdits to SignalLineEdits
- 722ea2fd - fix(signal_line_edit): red painter for SignalLineEdit fixed
-
1831505e...d8c80293 - 3 commits from branch
21 21 22 22 if entry is None or entry == "": 23 23 entry = next(iter(device._hints), name) if hasattr(device, "_hints") else name 24 if entry == "readback": Hm, based on what we saw for epics motor (https://github.com/bluesky/ophyd/blob/5df3f5694f5c4c0ac049f0e601512f220e85744b/ophyd/epics_motor.py#L43)… i am tempted to vote for what we get from describe/describe_configuration… might really be much safer..