Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

Draft: fix(curve_dialog): changed LineEdits to SignalLineEdits

Open wyzula_j requested to merge fix/signal-line-edits-in-curve-dialog into main
1 unresolved thread

Description

Change LineEdits of curve_dialog to SignalLineEdits

Related Issues

closes #394

Type of Change

  • Changed curve dialog line edits to use signal line edits

Potential side effects

@appel_c Not sure if this is bug with SignalLineEdit or CurveDialog, but the SignalLineEdit is always red even though the signal is correct. In Designer I have same problem. Can you check it?

Screenshots / GIFs (if applicable)

[Include any relevant screenshots or GIFs to showcase the changes made.]

Additional Comments

  • Waveform widget works, however SignalLineEdit is always red from some reason. You can try just to run widgets/waveform/waveform_widget.py
  • tests will be fixed later when the appearance of signal line edits is fixed

Definition of Done

  • Documentation is up-to-date.
Edited by wyzula_j

Merge request reports

Merge request pipeline #40424 failed

Merge request pipeline failed for 722ea2fd

Requires 1 approval from eligible users and Coverage-Check.
Test summary results are being parsed
Merge blocked: 4 checks failed
All required approvals must be given.
Merge request must not be draft.
Merge conflicts must be resolved.
Merge request must be rebased, because a fast-forward merge is not possible.

Merge details

  • The source branch is 141 commits behind the target branch.
  • 2 commits will be added to main.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
21 21
22 22 if entry is None or entry == "":
23 23 entry = next(iter(device._hints), name) if hasattr(device, "_hints") else name
24 if entry == "readback":
Please register or sign in to reply
Loading