Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content
Snippets Groups Projects

Plot Base next gen refactor

Merged wyzula_j requested to merge feat/plot-base-property into main
All threads resolved!

Description

A new PlotBase based on QWidget with a toolbar and a side panel. All common actions, such as scaling, title, axis configuration, and log settings, are available to all inherited widgets without code duplication. All configurable parameters are exposed as QProperties, making their state savable in INI files and adjustable directly in Qt Designer. A default side panel widget is provided to configure all axis properties directly within the widget itself.

Related Issues

Type of Change

  • Added new PlotBase
  • Introduced AxisSetting widget

Potential Side Effects

Old widgets will remain on the legacy BECPlotBase until all visualization widgets are migrated to the new PlotBase.

Definition of Done

  • Unit tests
Edited by wyzula_j

Merge request reports

Merge request pipeline #48254 passed with warnings

Merge request pipeline passed with warnings for e7c97290

Test coverage 80.00% (0.00%) from 1 job
Test summary results are being parsed

Merged by wyzula_jwyzula_j 3 days ago (Jan 30, 2025 4:01pm UTC)

Loading

Pipeline #48272 passed with warnings

Pipeline passed with warnings for e7c97290 on main

Test coverage 80.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • wakonig_k
    • Resolved by wyzula_j

      looks good to me... I think we don't have to test the functionality atm; we can do that with the upcoming refactoring of e.g. WaveformWidget

  • wyzula_j added 1 commit

    added 1 commit

    • ebb349ad - fix(plot_base): Removed USER_ACCESS

    Compare with previous version

  • wyzula_j added 2 commits

    added 2 commits

    • 48fc63d8 - fix(generate_cli): widgets can be tagged with RPC=False, then they are...
    • e7c97290 - feat(plot_base_next_gen): new type of plot base inherited from QWidget

    Compare with previous version

  • wakonig_k approved this merge request

    approved this merge request

  • wyzula_j resolved all threads

    resolved all threads

  • wyzula_j enabled an automatic merge when all merge checks for e7c97290 pass

    enabled an automatic merge when all merge checks for e7c97290 pass

  • merged

  • wyzula_j mentioned in issue #405 (closed)

    mentioned in issue #405 (closed)

  • Please register or sign in to reply
    Loading