Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

Add e2e test, cleanup and minor fixes

appel_c requested to merge refactor/widget_cleanup_logic into pre_release_v2

Description

This MR consist of multiple small improvements. It re-enables certain widget for usage via CLI (RPC #511 (closed) ), it adds proper parent passing for ModularToolBar, ToolBarActions and DockArea (#509 (closed)), fixes cleanup for Ring objects of RingProgressBar, deprecates widget_name in favor of object_name and lastly also adds simple method scoped e2e test for all available widget through the cli (#510 (closed)). This MR was split from !462 (closed), to first implement function scoped e2e tests in contrast to session based tests. A session based testing of the widgets, including a potential remove of --flush-redis from the CLI run will be tackled in a different MR (#508 (closed))

Related Issues

closes #511 (closed) #510 (closed) #509 (closed) #496 (closed) #499 (closed)

Additional Comments

Session based tests should be followed up soonish #508 (closed) . There is one side-effect, namely that the LaunchWindow now has the DarkModeButton properly attached to it and is no longer popping up after closing a dock_area (#512 (closed)).

Definition of Done

  • Documentation is up-to-date.
Edited by appel_c

Merge request reports