Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

parent id fix

wyzula_j requested to merge fix/parent-id-passing into pre_release_v2

Description

The parent_id is now a property that always fetches the current parent from the actual BEC widget, ensuring consistency. This removes the need to manually specify the parent and instead relies more on Qt's built-in parent resolution. It should also help prevent the occasional leakage of items with incorrect parents.

All affected widgets have been updated accordingly.

Related Issues

closes #544 (closed),

Type of Change

  • fix: Added deleteLater to BECDock to prevent leakage when closed (PyQtGraph bug).
  • fix: The argument bundle in ScanControl removal now also calls .close() in addition to .deleteLater.
  • fix: parent_id is now a property dynamically fetched from BECConnecter when accessed.
  • fix: Widgets can now be flagged as root_widgets, allowing them to skip the main window when used via the CLI (e.g., BECDockArea launched with IPythonClient).

Potential Side Effects

I believe all hardcoded parent_id usages have been removed—I’ve scanned the entire repository to ensure this.

Additional Comments

Please test the CLI thoroughly and check whether any objects are still leaking into the namespace.

Edited by wyzula_j

Merge request reports