Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

Refactor/refactor base class for custom integration

appel_c requested to merge refactor/refactor_base_class_for_custom_integration into main

Description

This MR reviewed the PSIDetectorBase class, cleaned it up and renamed it to PSIDeviceBase. The old class will be kept until beamline repositories are transitioned. In addition, the DelayGeneratorDG645 was reviewed. The communication and control implementation within EPICs was moved to the device section. An example for the config is provided.

Note The MockPV had to be adjusted to account for different write/read PVs that are not _RBV. This fix was easy. A second fix was required to the cl mocks, linked to PseudoDevices. I managed to mock that they would be accepted through wait_for_connection, however, they are not properly mocked, thus not function. In order to add tests for this, we have to investigate how to properly mock the PseudoPositioner forward/inverse methods. I made an issue #91.**

Related Issues

closes #89 closes #88

Definition of Done

  • Documentation is up-to-date.
Edited by appel_c

Merge request reports