Resolve "Undulator Test"

Closes #96 (closed)

assigned to @albajacas_a

added 1 commit

• 330f7019 - first files for undulator test

Compare with previous version

added 1 commit

• 67fa52b9 - add out file for undulator test

Compare with previous version

added 1 commit

• 6dd5771b - finalising test

Compare with previous version

added 2 commits

• a1955c5f - update reference files
• 3687d8dc - update gitignore

Compare with previous version

@gsell This test only works if OPAL is compiled with the -DENABLE_OPAL_FEL=yes flag. How can I deal with this? How is OPAL compiled for the nightly tests? Thanks

unmarked as a Work In Progress

@gsell I can add the cmake_config+=( "-DENABLE_OPAL_FEL=yes" ) to conf/cmake.conf, but then we somehow need to separately build the MITHRA library or have a module load mithra available.

Also, do I need to add this test to conf/regression_tests.conf? I don't understand how the cases that are/aren't on that list are chosen.

@albajacas_a to run the regression-tests you should clone git@gitlab.psi.ch:OPAL/NightlyBuild.git and use the script run-reg-tests.py. This script can be used with your OPAL binary. You can specify the tests you want to run on the command line. The script required Python 3 and the pathlib module.

As soon as I have build a MITHRA module you can also use the script run-tests. This is the script used for compiling OPAL, running the unit- and regression-tests. This script can be configured to run with your forks and branches. Run ./scripts/run-tests --help to get an idea how to use it.

The file confusion/regression_tests.conf not used any more. By default all regression-tests are run. To disable a test you have to create a file need disabled in the directory of the regression-tests.

Thank you @gsell ll. I've already run the tests and they work fine for me because I've compiled with MITHRA. My issue is that if I merge this MR the nightly regression tests will fail if the OPAL_FEL flag is not used.

So to solve this, I think that I should do the following:

1. add the cmake_config+=( "-DENABLE_OPAL_FEL=yes" ) to conf/cmake.conf.
2. add load module MITHRA to conf/modules.conf (once you have built the module)

Is that correct?

@albajacas_a Correct! But all this should be done in a fork/branch first. A MITHRA module will be available soon.

added 1 commit

• a43647b4 - add mithra module and OPAL_FEL flag for cmake

Compare with previous version

@albajacas_a The MITHRA module is ready for testing. I used 2020.8.27 as version since this is the date of the last commit and no versions tagged.

on Merlin:

module load gcc/8.4.0
module load openmpi/3.1.6_slurm
module load MITHRA/2020.8.27_slurm

on other systems with Modules available:

module load gcc/8.4.0
module load openmpi/3.1.6
module load MITHRA/2020.8.27

Thank you very much @gsell !

• Update module name to MITHRA/2.0 when it is available

added 1 commit

• 1f58fa70 - correct name mithra module

Compare with previous version

added 3 commits

• 69a3ee63 - make Undulator test a bit more precise
• 3241a891 - Update Undulator tests to work with MITHRA 2.0
• 34244dd5 - update mithra module

Compare with previous version

merged

mentioned in commit f8b7bca6